Re: [PATCH master 1/2] list: fix CONFIG_DEBUG_LIST link failure in PBL

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 16.05.24 09:16, Sascha Hauer wrote:
> On Wed, May 15, 2024 at 08:07:57AM +0200, Ahmad Fatoum wrote:
>> With the addition of PBL handoff data, we now use <linux/list.h> in PBL.
>> This works fine with CONFIG_DEBUG_LIST disabled, because all functions are
>> inlined, but when building with the option enabled, references to the
>> out-of-line sanity checking functions breaks the build.
>>
>> Fix this by omitting these references when building for PBL.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  include/linux/list.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/list.h b/include/linux/list.h
>> index 2b3a39ea81e8..e47a8188e807 100644
>> --- a/include/linux/list.h
>> +++ b/include/linux/list.h
>> @@ -36,7 +36,7 @@ static inline void INIT_LIST_HEAD(struct list_head *list)
>>  	list->prev = list;
>>  }
>>  
>> -#ifdef CONFIG_DEBUG_LIST
>> +#if defined(CONFIG_DEBUG_LIST) && !defined(__PBL__)
>>  extern bool __list_add_valid_or_report(struct list_head *new,
>>  				       struct list_head *prev,
>>  				       struct list_head *next);
> 
> What about compiling list_debug.o for PBL as well?

I'd prefer we use singly linked lists instead, but I want to fix the
build error first.

Thanks,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |