From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 17 May 2024 08:02:45 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s7qg1-000rvG-0B for lore@lore.pengutronix.de; Fri, 17 May 2024 08:02:45 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7qg0-0000Yz-Ga for lore@pengutronix.de; Fri, 17 May 2024 08:02:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i1CKaCmxVpOgoRczao2WnA5wmHdBXG+Ox8hYjf/x1As=; b=Hq32fXtvIesttsODpIGwxMG2xR h2ffif4p/No31GyItKPs0FFgNqDFq/cV5qj+qiiH7hylGJq63Q+bbFaxo3bKxxUMH/Bah+bPWv20v AsDYoR3oHYqBjro1AEyiQEaea6wUUUrxWojpXlRG72cITGOQ0uEsXNdZv+4/lj6Bpqt7pKYmKSksX feSveu1ffodFvTifPuMJLyoPi+Ht2YRG1UNLUqkr/C0AxX4qAb41G2tRqWzAGnQYzTEDsnx1//tI1 FanhRmaDsKlWwuocwmkXufzH1UHdYQE+YgiNKf1fqb0AfOo+GTXxeoU+8v7YkFmTkPSvsUEDhZ4hU xnRQT4EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7qfU-00000006uIl-3Vaw; Fri, 17 May 2024 06:02:12 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7qfP-00000006uIL-0JGu for barebox@lists.infradead.org; Fri, 17 May 2024 06:02:11 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s7qfN-0000Ji-CN; Fri, 17 May 2024 08:02:05 +0200 Message-ID: <4bd8c696-762a-46ed-9835-db41b96dda1f@pengutronix.de> Date: Fri, 17 May 2024 08:02:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: barebox@lists.infradead.org References: <20240515060758.3580734-1-a.fatoum@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_230207_153649_7FBA8EF3 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master 1/2] list: fix CONFIG_DEBUG_LIST link failure in PBL X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 16.05.24 09:16, Sascha Hauer wrote: > On Wed, May 15, 2024 at 08:07:57AM +0200, Ahmad Fatoum wrote: >> With the addition of PBL handoff data, we now use in PBL. >> This works fine with CONFIG_DEBUG_LIST disabled, because all functions are >> inlined, but when building with the option enabled, references to the >> out-of-line sanity checking functions breaks the build. >> >> Fix this by omitting these references when building for PBL. >> >> Signed-off-by: Ahmad Fatoum >> --- >> include/linux/list.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/list.h b/include/linux/list.h >> index 2b3a39ea81e8..e47a8188e807 100644 >> --- a/include/linux/list.h >> +++ b/include/linux/list.h >> @@ -36,7 +36,7 @@ static inline void INIT_LIST_HEAD(struct list_head *list) >> list->prev = list; >> } >> >> -#ifdef CONFIG_DEBUG_LIST >> +#if defined(CONFIG_DEBUG_LIST) && !defined(__PBL__) >> extern bool __list_add_valid_or_report(struct list_head *new, >> struct list_head *prev, >> struct list_head *next); > > What about compiling list_debug.o for PBL as well? I'd prefer we use singly linked lists instead, but I want to fix the build error first. Thanks, Ahmad > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |