Re: [PATCH 05/10] mci: describe more command structure in mci.h

[Yann Sionneau <ysionneau@kalrayinc.com>]

Hello Ahmad,

Le 7/30/24 à 09:19, Ahmad Fatoum a écrit :
> This introduces no functional change, but adds a number of definitions
> that will come in handy when adding erase support in a later commit.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>   include/mci.h | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 60 insertions(+), 1 deletion(-)
>
> diff --git a/include/mci.h b/include/mci.h
> index 4f1ff9dc57c8..610040937ee5 100644
> --- a/include/mci.h
> +++ b/include/mci.h
>
> +/*
> + * Card Command Classes (CCC)
> + */
> +#define CCC_BASIC		(1<<0)	/* (0) Basic protocol functions */
> +					/* (CMD0,1,2,3,4,7,9,10,12,13,15) */
> +					/* (and for SPI, CMD58,59) */
> +#define CCC_STREAM_READ		(1<<1)	/* (1) Stream read commands */
> +					/* (CMD11) */
> +#define CCC_BLOCK_READ		(1<<2)	/* (2) Block read commands */
> +					/* (CMD16,17,18) */
> +#define CCC_STREAM_WRITE	(1<<3)	/* (3) Stream write commands */
> +					/* (CMD20) */
> +#define CCC_BLOCK_WRITE		(1<<4)	/* (4) Block write commands */
> +					/* (CMD16,24,25,26,27) */
> +#define CCC_ERASE		(1<<5)	/* (5) Ability to erase blocks */
> +					/* (CMD32,33,34,35,36,37,38,39) */
> +#define CCC_WRITE_PROT		(1<<6)	/* (6) Able to write protect blocks */
> +					/* (CMD28,29,30) */
> +#define CCC_LOCK_CARD		(1<<7)	/* (7) Able to lock down card */
> +					/* (CMD16,CMD42) */
> +#define CCC_APP_SPEC		(1<<8)	/* (8) Application specific */
> +					/* (CMD55,56,57,ACMD*) */
> +#define CCC_IO_MODE		(1<<9)	/* (9) I/O mode */
> +					/* (CMD5,39,40,52,53) */
> +#define CCC_SWITCH		(1<<10)	/* (10) High speed switch */
> +					/* (CMD6,34,35,36,37,50) */
> +					/* (11) Reserved */
> +					/* (CMD?) */
> +

Why not use BIT(xx)? Maybe this is copy paste from Linux and you want to 
keep it easy to synchronize?

-- 

Yann