Re: [PATCH 7/7] efi: payload: add options for FDT force and initrd direct install

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Anis,

On 8/31/25 5:55 AM, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
> 
> Signed-off-by: Chali Anis <chalianis1@gmail.com>
> ---
>  efi/Kconfig | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/efi/Kconfig b/efi/Kconfig
> index 84f670fd23d3..c3811574920d 100644
> --- a/efi/Kconfig
> +++ b/efi/Kconfig
> @@ -50,4 +50,21 @@ config EFI_PAYLOAD_DEFAULT_PATH
>  
>  endif
>  
> +config EFI_FDT_FORCE
> +	bool "Force EFI provided FDT"
> +	default n

n is the default

> +	help
> +	  with this options we keep the fdt passed by EFI in the
> +	  system configuration table, EFI has to suppot FDT otherwise
> +	  an empty fdt will be generated when linux boots by efi.

These things should be runtime configurable and not in Kconfig.
Why can't you take a user-supplied FDT if there is one and otherwise
fall back to of_get_fixed_tree_for_boot() as fallback?

> +config EFI_INITRD_INSTALL
> +	bool "Install the initramfs by barebox"
> +	default n
> +	help
> +	  with this option barebox will install the initrd to the
> +	  system configuration table, same as what kernel do after
> +	  calling read file2 boot services, in this case the initrd
> +	  will be read directly by the kernel as an initramfs.

Same thing, why can't we check for data->initrd and use that?

Cheers,
Ahmad

> +
>  endmenu

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |