mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: 张忠山 <zzs213@126.com>
To: barebox@lists.infradead.org
Subject: maybe bug in common/ddr_spd.c
Date: Tue, 9 Apr 2019 17:56:53 +0800 (CST)	[thread overview]
Message-ID: <4eb7d5fd.88a6.16a01876e6b.Coremail.zzs213@126.com> (raw)

Maybe this is a bug, I'm not sure

-----------------------------------8<----------------------------- 
From 55509f359abbb1f5c24e9f0c2b9cff167f62ae4d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BC=A0=E5=BF=A0=E5=B1=B1?= <zzs213@126.com>
Date: Mon, 8 Apr 2019 14:34:00 +0800
Subject: [PATCH] bugfix: check ddr mod_ranks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: 张忠山 <zzs213@126.com>
---
 common/ddr_spd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/ddr_spd.c b/common/ddr_spd.c
index ec343ef5a..277d418e9 100644
--- a/common/ddr_spd.c
+++ b/common/ddr_spd.c
@@ -253,7 +253,7 @@ void ddr_spd_print(uint8_t *record)
 		printf("Error module type\n");
 
 	printf("%-48s ", "DRAM Package ");
-	if ((s->mod_ranks & 0x10) == 1)
+	if ((s->mod_ranks & 0x10) != 0)
 		printf("Stack\n");
 	else
 		printf("Planar\n");
-- 
2.21.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2019-04-09  9:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  9:56 张忠山 [this message]
2019-04-10  6:26 ` Sascha Hauer
2019-04-10 16:49   ` Ladislav Michl
2019-04-11  8:03     ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eb7d5fd.88a6.16a01876e6b.Coremail.zzs213@126.com \
    --to=zzs213@126.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox