mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Daniel Brát" <danek.brat@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH] i2c: add bcm283x i2c host controller support
Date: Tue, 14 Jun 2022 11:52:26 +0200	[thread overview]
Message-ID: <4f2eca20-3afa-d521-fa02-55070140f759@pengutronix.de> (raw)
In-Reply-To: <20220611212842.6413-1-danek.brat@gmail.com>

Hello Daniel,

Thanks for your patch.

On 11.06.22 23:28, Daniel Brát wrote:
> Add a driver to support the i2c host controller (BSC)
> found on bcm283x family os SoCs.

s/os/of/

> 
> Signed-off-by: Daniel Brát <danek.brat@gmail.com>
> ---
>  arch/arm/configs/rpi_v8a_defconfig |   3 +-

You can enable it for rpi_defconfig too

>  drivers/i2c/busses/Kconfig         |   4 +
>  drivers/i2c/busses/Makefile        |   1 +
>  drivers/i2c/busses/i2c-bcm283x.c   | 372 +++++++++++++++++++++++++++++
>  4 files changed, 379 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/i2c/busses/i2c-bcm283x.c
> 
> diff --git a/arch/arm/configs/rpi_v8a_defconfig b/arch/arm/configs/rpi_v8a_defconfig
> index 68cd2438b..e218311a7 100644
> --- a/arch/arm/configs/rpi_v8a_defconfig
> +++ b/arch/arm/configs/rpi_v8a_defconfig
> @@ -81,6 +81,8 @@ CONFIG_SERIAL_AMBA_PL011=y
>  CONFIG_DRIVER_SERIAL_NS16550=y
>  CONFIG_NET_USB=y
>  CONFIG_NET_USB_SMSC95XX=y
> +CONFIG_I2C=y
> +CONFIG_I2C_BCM283X=y
>  CONFIG_USB_HOST=y
>  CONFIG_USB_DWC2_HOST=y
>  CONFIG_USB_DWC2_GADGET=y
> @@ -108,4 +110,3 @@ CONFIG_FS_FAT=y
>  CONFIG_FS_FAT_WRITE=y
>  CONFIG_FS_FAT_LFN=y
>  CONFIG_ZLIB=y
> -CONFIG_LZO_DECOMPRESS=y
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 58f865606..429f5ba42 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -17,6 +17,10 @@ config I2C_AT91
>  	bool "AT91 I2C Master driver"
>  	depends on ARCH_AT91
>  
> +config I2C_BCM283X
> +	bool "BCM283X I2C Master driver"
> +	depends on ARCH_BCM283X

|| COMPILE_TEST

> +			if (ret) {
> +				dev_err(dev, "timeout: 10bit addr "
> +					     "read initilization\n");

Don't line-break strings. It needlessly complicates searching for messages
in the code. Also you don't need to adhere religiously to 80 characters.
Up to 100 characters is usually ok. If you go beyond that, reevaluate
if it wouldn't be more readable to reduce indentation.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2022-06-14  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11 21:28 Daniel Brát
2022-06-14  9:41 ` Sascha Hauer
2022-06-14  9:52 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2eca20-3afa-d521-fa02-55070140f759@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=danek.brat@gmail.com \
    --subject='Re: [PATCH] i2c: add bcm283x i2c host controller support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox