mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: chalianis1@gmail.com, s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ehci-zynq: variscite: tee: fix many typos struct device.
Date: Thu, 27 Nov 2025 10:23:44 +0100	[thread overview]
Message-ID: <4f49a9b2737dae6f067e00ff1aa74d95a7f89e48.camel@pengutronix.de> (raw)
In-Reply-To: <20251127045417.3490877-1-chalianis1@gmail.com>

Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb
chalianis1@gmail.com:
> From: Chali Anis <chalianis1@gmail.com>
> 
> fix struct device_d to struct device.

It's not really a typo, as struct device was called struct device_d for
a long time in barebox. You are fixing the last remnants of that. I'm
not sure if it's a good idea to lump all those different sites into a
single patch. At least the subject doesn't really make sense, as zynq,
a board and tee are not one subsystem.

Also, now that you remove the last usages of the deprecated device_d
you can also remove the
#define device_d device in driver.h

Regards,
Lucas

> 
> Signed-off-by: Chali Anis <chalianis1@gmail.com>
> ---
>  arch/arm/boards/variscite-som-mx7/board.c | 2 +-
>  drivers/usb/host/ehci-zynq.c              | 2 +-
>  include/linux/tee_drv.h                   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boards/variscite-som-mx7/board.c b/arch/arm/boards/variscite-som-mx7/board.c
> index 005228d107af..8bce4ec8616d 100644
> --- a/arch/arm/boards/variscite-som-mx7/board.c
> +++ b/arch/arm/boards/variscite-som-mx7/board.c
> @@ -5,7 +5,7 @@
>  #include <deep-probe.h>
>  #include <mach/imx/bbu.h>
>  
> -static int var_som_mx7_probe(struct device_d *dev)
> +static int var_som_mx7_probe(struct device *dev)
>  {
>  	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
>  	return 0;
> diff --git a/drivers/usb/host/ehci-zynq.c b/drivers/usb/host/ehci-zynq.c
> index 13b551d09156..b4b0e0f89100 100644
> --- a/drivers/usb/host/ehci-zynq.c
> +++ b/drivers/usb/host/ehci-zynq.c
> @@ -6,7 +6,7 @@
>  #include <common.h>
>  #include <linux/usb/ulpi.h>
>  
> -static int zynq_ehci_probe(struct device_d *dev)
> +static int zynq_ehci_probe(struct device *dev)
>  {
>  	struct resource *res;
>  	void __iomem *base;
> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> index e2c1042debce..6a8e19459f47 100644
> --- a/include/linux/tee_drv.h
> +++ b/include/linux/tee_drv.h
> @@ -201,7 +201,7 @@ struct tee_shm {
>  	struct list_head link;
>  
>  	int fd;
> -	struct device_d dev;
> +	struct device dev;
>  	struct cdev cdev;
>  	struct resource res;
>  };
> 




  reply	other threads:[~2025-11-27  9:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27  4:54 chalianis1
2025-11-27  9:23 ` Lucas Stach [this message]
2025-11-27  9:27   ` Ahmad Fatoum
2025-11-27 11:42 ` Sascha Hauer
2025-11-27 11:43 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f49a9b2737dae6f067e00ff1aa74d95a7f89e48.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=chalianis1@gmail.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox