mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Jürgen Kilb" <J.Kilb@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM omap hsmmc: Fix adding iobase for OMAP3
Date: Mon, 07 Jan 2013 16:02:17 +0100	[thread overview]
Message-ID: <50EAE379.2020702@phytec.de> (raw)
In-Reply-To: <20130107092324.GH1906@pengutronix.de>

Hi Sascha,

On 07.01.2013 10:23, Sascha Hauer wrote:
> Hi Jürgen,
>
> On Fri, Jan 04, 2013 at 05:13:12PM +0100, Juergen Kilb wrote:
>> Only the OMAP4 hsmmc module has an offset of 0x100 from its register
>> base address. With commit 416a991 the offset was added for all SOCs
>> which use the omap_hsmmc driver.
> The offset was present before 416a991 aswell. It seems that the device
> convenience functions introduced with bc872dbe79 did it wrong for OMAP3.
> When then the boards started using the convenience functions with
> 5a12f45 it became broken.
OK, I've not dug deeper...
> I prefer to fix this properly. Does the following fix it for you?
Yes, your patch looks better then my simple version.
Your patch fixed it for me.
You can add my "Tested-by: J.Kilb@Phytec.de" line.

thanks,
Jürgen

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-01-07 15:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04 16:13 Juergen Kilb
2013-01-07  9:23 ` Sascha Hauer
2013-01-07 15:02   ` Jürgen Kilb [this message]
2013-01-09 11:00 ` Sascha Hauer
2013-01-09 12:42   ` Jürgen Kilb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EAE379.2020702@phytec.de \
    --to=j.kilb@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox