From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 31 May 2023 12:10:17 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q4ImY-0047C1-I4 for lore@lore.pengutronix.de; Wed, 31 May 2023 12:10:17 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4ImW-0000ao-6R for lore@pengutronix.de; Wed, 31 May 2023 12:10:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D32ZstGFSZ27+gxjQKKTpWtkhXQIJwc7MFzA7aKBmpk=; b=E2u+/ZjZLZrhNsiAMvG2vuAPuG ugRagIUXy8Os3SX9aC7a3gRP50AjuJZV4k4eTRViIB+ZfMkViY0rgG2oeDOkXIuL3UReAhlsN6JPl cAJESNzqeTQSEd1NXN2X5BgLCvfWIhEf26FuRq6TlMeEGZZpx2ptXIeeUZY4xkAhqdh+Wap3FKobE HrVHNVV5ztdO7EO9sUsx+IBIkG9SF0PlGgIjtn76ScKGNtXt6h/RenPc/8brP4ja3skybrkUoUz59 LOQazeio3Ra9ef9t2jZm5dvlYVIBUixD+9lx+5iJFU8wuq5fD0ReJzPZbmA1Tetl9rBFSJ6j+ATr8 HwT7jDHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4IlH-00GxQm-1N; Wed, 31 May 2023 10:08:59 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4IlE-00GxQ7-24 for barebox@lists.infradead.org; Wed, 31 May 2023 10:08:58 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q4IlC-0000Ll-FE; Wed, 31 May 2023 12:08:54 +0200 Message-ID: <511011db-b8a8-1ddb-851f-81930f8de259@pengutronix.de> Date: Wed, 31 May 2023 12:08:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Sascha Hauer , Barebox List References: <20230531100128.819492-1-s.hauer@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230531100128.819492-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_030856_694811_5730B046 X-CRM114-Status: GOOD ( 21.99 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 1/2] ARM: set zero page accessible before copying ATAGs there X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 31.05.23 12:01, Sascha Hauer wrote: > We used skip setting up the zero page as faulting when the SDRAM > starts at 0x0. One reason for doing that was that ATAGs will be copied > there in that case. Call zero_page_access() if necessary to be able > to set the zero page to faulting during barebox startup in the next > step. > > Signed-off-by: Sascha Hauer > --- > arch/arm/lib32/armlinux.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/lib32/armlinux.c b/arch/arm/lib32/armlinux.c > index 6cb7d4b5f3..9b2f1f4544 100644 > --- a/arch/arm/lib32/armlinux.c > +++ b/arch/arm/lib32/armlinux.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -265,8 +266,12 @@ void start_linux(void *adr, int swap, unsigned long initrd_address, > pr_debug("booting kernel with devicetree\n"); > params = oftree; > } else { > - setup_tags(initrd_address, initrd_size, swap); > params = armlinux_get_bootparams(); > + > + if ((unsigned long)params <= PAGE_SIZE) > + zero_page_access(); Just < should be enough, no? > + > + setup_tags(initrd_address, initrd_size, swap); > } > architecture = armlinux_get_architecture(); > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |