mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org, Brian Lilly <brian@crystalfontz.com>
Subject: Re: [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment
Date: Thu, 14 Feb 2013 11:10:54 +0100	[thread overview]
Message-ID: <511CB82E.9030105@free-electrons.com> (raw)
In-Reply-To: <201302140916.36347.jbe@pengutronix.de>

Hi Juergen,

Le 14/02/2013 09:16, Juergen Beisert a écrit :
> Maxime Ripard wrote:
>> Since the only storage medium on the cfa-10036 is the MMC card, we need
>> to have a registered environment partition on it if we want to be able
>> to modify at runtime.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>  arch/arm/boards/crystalfontz-cfa10036/cfa10036.c |   44
>> +++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
>> index b59dbab..1821b10 100644 
>> --- a/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
>> +++ b/arch/arm/boards/crystalfontz-cfa10036/cfa10036.c
>> @@ -97,9 +97,46 @@ static int cfa10036_mem_init(void)
>>  }
>>  mem_initcall(cfa10036_mem_init);
>>
>> +/**
>> + * Try to register an environment storage on the attached MCI card
>> + * @return 0 on success
>> + *
>> + * We rely on the existence of a usable SD card, already attached to
>> + * our system, to get something like a persistent memory for our environment.
>> + * If this SD card is also the boot media, we can use the second partition
>> + * for our environment purpose (if present!). 
>> + */
>> +static int register_persistant_environment(void)
> 
> register_persist*e*nt_environment
> 
> Seems a copy from my typo in the falconwing. I really should fix it :))

Oops :)
I will fix it, it will probably end up in a common function anyway.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-02-14 10:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 16:45 [PATCH 0/2] ARM: cfa10036: Store the barebox environment on the MMC Maxime Ripard
2013-02-13 16:45 ` [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment Maxime Ripard
2013-02-13 17:10   ` Eric Bénard
2013-02-13 17:12   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-14  9:52     ` Maxime Ripard
2013-02-14  8:16   ` Juergen Beisert
2013-02-14 10:10     ` Maxime Ripard [this message]
2013-02-14 11:17       ` Eric Bénard
2013-02-14 11:56         ` [PATCH 1/3] env: add register_persistent_environment Eric Bénard
2013-02-14 11:56           ` [PATCH 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-14 11:56           ` [PATCH 3/3] falconwing: switch " Eric Bénard
2013-02-14 12:09             ` Juergen Beisert
2013-02-14 13:20               ` [PATCH v2] " Eric Bénard
2013-02-14 13:50                 ` [PATCH v3] " Eric Bénard
2013-02-14 19:31           ` [PATCH 1/3] env: add register_persistent_environment Sascha Hauer
2013-02-19  9:17             ` [PATCH v4 " Eric Bénard
2013-02-19  9:17               ` [PATCH v4 2/3] imx23-olinuxino: swith to generic peristent env Eric Bénard
2013-02-19  9:17               ` [PATCH v4 3/3] falconwing: switch " Eric Bénard
2013-02-19 11:58               ` [PATCH v4 1/3] env: add register_persistent_environment Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 13:41                 ` Eric Bénard
2013-02-19 15:35                   ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-19 15:49                     ` Eric Bénard
2013-02-19 15:57                       ` Eric Bénard
2013-02-19 19:21                         ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21  6:55                           ` Eric Bénard
2013-02-21 11:20                             ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-21 13:52               ` Sascha Hauer
2013-02-13 16:45 ` [PATCH 2/2] cfa10036: Update the environment Maxime Ripard
2013-02-26 16:50 [PATCHv2 0/2] ARM: cfa10036: Store the barebox environment on the MMC Maxime Ripard
2013-02-26 16:50 ` [PATCH 1/2] cfa-10036: Use the second MMC partition to store the environment Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511CB82E.9030105@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=barebox@lists.infradead.org \
    --cc=brian@crystalfontz.com \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox