* [PATCH 2/5] at91udc: startup fix
@ 2013-03-13 13:41 Cerrato Renaud
0 siblings, 0 replies; only message in thread
From: Cerrato Renaud @ 2013-03-13 13:41 UTC (permalink / raw)
To: barebox
I noticed that depending on boot timings, the USB gadget weren't detected at all by hosts. After few hours of debugging and using the at91clk output, I found that the UDP clock wasn't enabled from time to time.
This patch fix the startup of UDC by adding a check into the at91_update_vbus().
Signed-off-by: Cerrato Renaud <r.cerrato@til-technologies.fr>
---
drivers/usb/gadget/at91_udc.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 3899db2..0654038 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1327,6 +1327,12 @@ static void at91_update_vbus(struct at91_udc *udc, u32 value)
dev_set_param(udc->dev, "vbus", "0");
udc->gpio_vbus_val = value;
+ udc->vbus = value != 0;
+
+ if(udc->driver)
+ pullup(udc, udc->vbus);
+ else
+ pullup(udc, 0);
}
int usb_gadget_poll(void)
@@ -1508,7 +1514,7 @@ static int __init at91udc_probe(struct device_d *dev)
* Get the initial state of VBUS - we cannot expect
* a pending interrupt.
*/
- udc->vbus = gpio_get_value(udc->board.vbus_pin);
+ udc->vbus = gpio_get_value(udc->board.vbus_pin) ^ udc->board.vbus_active_low;
DBG(udc, "VBUS detection: host:%s \n",
udc->vbus ? "present":"absent");
} else {
@@ -1517,7 +1523,7 @@ static int __init at91udc_probe(struct device_d *dev)
}
dev_add_param(dev, "vbus", NULL, NULL, 0);
- dev_set_param(dev, "vbus", "0");
+ dev_set_param(dev, "vbus", udc->vbus ? "1" : "0");
poller_register(&poller);
--
1.7.2.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-13 13:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 13:41 [PATCH 2/5] at91udc: startup fix Cerrato Renaud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox