From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
barebox@lists.infradead.org
Subject: Re: [RFC 0/2] mci: Dove SDHCI driver
Date: Thu, 11 Jul 2013 00:51:23 +0200 [thread overview]
Message-ID: <51DDE56B.8090701@gmail.com> (raw)
In-Reply-To: <20130709173806.GW516@pengutronix.de>
On 07/09/2013 07:38 PM, Sascha Hauer wrote:
> On Fri, Jul 05, 2013 at 11:22:17PM +0200, Sebastian Hesselbarth wrote:
>> This RFC presents a working SDHCI driver for the IP found on Marvell
>> Dove SoCs.
>>
>> @Sascha: We talked about refactoring common SDHCI code and I just want
>> to show what I came up with for Dove. After thinking about existing barebox
>> SDHCI, I had the impression that I should reimplement Dove SDHCI with writel
>> as it is already made in other SDHCI drivers.
>
> Yes, common register accessors would make it possible to share code.
> Maybe we can start with some sdhc_write[bwl]/read[bwl] functions which
> are static inline wrappers around regular writel/readl. This would make
> it possible to add an indirection there should we have to.
Sascha,
a quick look at the SDHCI spec showed that the "native" word width is
16b. At least Dove allows you to read registers at any width, but there
may be other controllers with limited word width capabilities. Anyway,
I guess we should try to have the common code and the defines use those
16b reg width.
>> I will be not checking mails regularily nor working on Barebox for the next
>> two weeks, so feel free to simply ignore the RFC. But I thought it will be
>> a good way to discuss your plans for common SDHCI code.
>
> I think the driver looks mostly good. It should be a good base to factor
> out common code in the future.
Ok, when I get back to this, I will prepare a real patch for it.
Sebastian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-07-10 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 21:22 Sebastian Hesselbarth
2013-07-05 21:22 ` [RFC 1/2] mci: add more defines to sdhci include Sebastian Hesselbarth
2013-07-05 21:22 ` [RFC 2/2] mci: add Marvell Dove SDHCI driver Sebastian Hesselbarth
2015-02-17 23:43 ` Michael Grzeschik
2015-02-18 19:34 ` Sebastian Hesselbarth
2015-02-19 11:59 ` Michael Grzeschik
2013-07-09 17:38 ` [RFC 0/2] mci: " Sascha Hauer
2013-07-10 22:51 ` Sebastian Hesselbarth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DDE56B.8090701@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox