From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-x234.google.com ([2a00:1450:4008:c01::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V9FVA-00015Q-FQ for barebox@lists.infradead.org; Tue, 13 Aug 2013 14:23:13 +0000 Received: by mail-bk0-f52.google.com with SMTP id e11so2649901bkh.25 for ; Tue, 13 Aug 2013 07:22:47 -0700 (PDT) Message-ID: <520A4133.6040908@gmail.com> Date: Tue, 13 Aug 2013 16:22:43 +0200 From: Sebastian Hesselbarth MIME-Version: 1.0 References: <1376378772-25649-1-git-send-email-s.hauer@pengutronix.de> <1376378772-25649-4-git-send-email-s.hauer@pengutronix.de> <520A34FE.2020008@gmail.com> <20130813141516.GT26614@pengutronix.de> In-Reply-To: <20130813141516.GT26614@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/6] ARM: mvebu: introduce multi image support To: Sascha Hauer Cc: Thomas Petazzoni , barebox@lists.infradead.org On 08/13/13 16:15, Sascha Hauer wrote: > On Tue, Aug 13, 2013 at 03:30:38PM +0200, Sebastian Hesselbarth wrote: >> On 08/13/13 09:26, Sascha Hauer wrote: >>> diff --git a/arch/arm/boards/solidrun-cubox/lowlevel.c b/arch/arm/boards/solidrun-cubox/lowlevel.c >>> new file mode 100644 >>> index 0000000..fdf5a7e >>> --- /dev/null >>> +++ b/arch/arm/boards/solidrun-cubox/lowlevel.c >>> @@ -0,0 +1,37 @@ >> [...] >>> +ENTRY_FUNCTION(start_solidrun_cubox)(void) >>> +{ >>> + uint32_t fdt; >>> + >>> + __barebox_arm_head(); >>> + >>> + arm_cpu_lowlevel_init(); >>> + >>> + fdt = (uint32_t)__dtb_dove_cubox_start - get_runtime_offset(); >>> + >>> + mvebu_barebox_entry(fdt); >>> +} >> [...] >>> diff --git a/arch/arm/mach-mvebu/lowlevel.c >> b/arch/arm/mach-mvebu/lowlevel.c >>> index 3f64c4a..11810cc 100644 >>> --- a/arch/arm/mach-mvebu/lowlevel.c >>> +++ b/arch/arm/mach-mvebu/lowlevel.c >>> @@ -24,5 +24,5 @@ >>> void __naked barebox_arm_reset_vector(void) >>> { >>> arm_cpu_lowlevel_init(); >>> - mvebu_barebox_entry(); >>> + mvebu_barebox_entry(0); >>> } >> >> Sascha, >> >> thanks for the patch set, I'll give it a go soon. >> >> I understand that this is just a first step, but you are adding extra >> lowlevel init to boards/solidrun-cubox/lowlevel.c but in the end it >> should be part of mach-mvebu/lowlevel.c instead? >> >> I have a some MVEBU boards with Dove and Armada 370 available and >> could extend the patches to have a single lowlevel init again. > > The board specific lowlevel init is necessary since this specifies the > dtb to use. Otherwise there's no way to find out on which board you are > running on. Ok, but I could try to cook the board lowlevel init down to its bare minimum and only set fdt address. Or have some mvebu specific fdt_address variable that can be overwritten. The less board specific stuff there is, the better. Sebastian _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox