From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] gpio: Add designware gpio controller support
Date: Tue, 10 Sep 2013 10:56:52 +0200 [thread overview]
Message-ID: <522EDED4.700@gmail.com> (raw)
In-Reply-To: <20130910074816.GE30088@pengutronix.de>
On 09/10/2013 09:48 AM, Sascha Hauer wrote:
> On Mon, Sep 09, 2013 at 06:28:48PM +0200, Sebastian Hesselbarth wrote:
>> I have seen this driver and think it can be improved by exploiting
>> its config1/2 registers where synthesis settings are stored. Please
>> also look at [1] pp.1229; you can read out number of ports, port
>> width, interrupt, and debounce features.
>
> Ok, the port width feature is easy enough to implement. Will add it in
> the next version.
>
> I also added a check for multiple ports, but just ignore the additional
> ports for now since I don't know the register offsets and also have no
> hardware to actually test it (The SoCFPGA only has one port)
Ok, fair enough. IIRC the Armada 1500 uses multiple instances instead
of multiple ports, too.
>> Unfortunately, I am not ready to run barebox on Armada 1500 and I
>> don't have a socfpga to test. So if you are not eager to modify it now,
>> I can add config reg based read-out later.
>>
>> [1] http://www.altera.com/literature/hb/arria-v/hps.pdf
>>
>> [...]
>>> +static __maybe_unused struct of_device_id dwgpio_match[] = {
>>> + {
>>> + .compatible = "snps,dw-gpio",
>>> + }, {
>>
>> Please add "snps,dw-apb-gpio", that's what the linux driver
>> will look for if make to pick it up for Armada 1500.
>
> I'll better just change it to "snps,dw-apb-gpio". There already is a
> dtsi file in the kernel which uses this binding (although it looks like
> it hasn't been approved by anyone)
The driver got Acks, but must have slipped through. I have seen your
v2 but it still uses "snps,dw-gpio".
Sebastian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-10 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 14:54 Sascha Hauer
2013-09-09 16:28 ` Sebastian Hesselbarth
2013-09-10 7:48 ` Sascha Hauer
2013-09-10 8:56 ` Sebastian Hesselbarth [this message]
2013-09-11 6:35 ` Sascha Hauer
2013-10-17 8:04 ` Steffen Trumtrar
2013-10-17 8:24 ` Sebastian Hesselbarth
2013-10-17 8:38 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522EDED4.700@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox