From: Renaud Barbier <renaud.barbier@ge.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] ppc: DA923RC: add board support
Date: Thu, 31 Oct 2013 14:41:15 +0000 [thread overview]
Message-ID: <52726C0B.4070109@ge.com> (raw)
In-Reply-To: <20131030113452.GG26639@ns203013.ovh.net>
On 30/10/2013 11:34, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> + barebox_set_model("Unknown");
>> > +
>> > + /* Enable the GPIO Out pins */
>> > + out_be32(gur + MPC85xx_GPIOCR_OFFSET, (gpiocr | MPC85xx_GPIOCR_GPOUT));
> this should be GPIO API
>> > +
>> > + /* Enable NOR low voltage programming (gpio 2) an
Note that here the code enables a CPU function that is, the whole block
of pins is enabled to be used as GPIO out pin. This does not specify the
pins direction but the pins function.
Of course, this can be wrap in a function specific to the CPU.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-31 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 10:22 [PATCH v2 0/5] GEIP DA923RC " Renaud Barbier
2013-10-30 10:22 ` [PATCH 1/5] ppc: mpc85xx: mpc8544 support Renaud Barbier
2013-10-30 10:22 ` [PATCH 2/5] ppc: mpc85xx: define Ethernet port count Renaud Barbier
2013-10-30 10:22 ` [PATCH 3/5] ppc: mpc85xx: enable DDR driver Renaud Barbier
2013-10-30 10:22 ` [PATCH 4/5] ppc: DA923RC: add board support Renaud Barbier
2013-10-30 11:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 7:48 ` Sascha Hauer
2013-10-31 13:15 ` Renaud Barbier
2013-10-31 20:10 ` Renaud Barbier
2013-11-01 11:58 ` Sascha Hauer
2013-11-01 12:56 ` Renaud Barbier
2013-11-01 13:02 ` Renaud Barbier
2013-11-01 15:03 ` Renaud Barbier
2013-11-01 20:28 ` Sascha Hauer
2013-11-04 18:06 ` Renaud Barbier
2013-11-05 7:35 ` Sascha Hauer
2013-10-31 14:41 ` Renaud Barbier [this message]
2013-10-31 16:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 18:59 ` Renaud Barbier
2013-10-30 10:22 ` [PATCH 5/5] ppc: mpc85xx: build directives Renaud Barbier
2013-11-05 15:36 [PATCH v3 0/5] GEIP DA923RC board support Renaud Barbier
2013-11-05 15:36 ` [PATCH 4/5] ppc: DA923RC: add " Renaud Barbier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52726C0B.4070109@ge.com \
--to=renaud.barbier@ge.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox