From: Owen Kirby <osk@exegin.com>
To: barebox@lists.infradead.org
Subject: [PATCH] Fix the options and protocols used by the loadx command.
Date: Thu, 08 May 2014 13:36:14 -0700 [thread overview]
Message-ID: <536BEABE.9060705@exegin.com> (raw)
From 3cd970250ff17ac406e46e18ebb26aa35949d1db Mon Sep 17 00:00:00 2001
From: Owen Kirby <osk@exegin.com>
Date: Thu, 8 May 2014 13:27:11 -0700
Subject: [PATCH] Fix the options and protocols used by the loadx command.
It seems like the loadx command was improperly copy/pasted from the loady
implementation, and was trying to load files using the ymodem protocol. This
patch should fix the command so that it uses xmodem, implements the -t option
and outputs the correct baudrate being used.
Signed-off-by: Owen Kirby <osk@exegin.com>
---
commands/loadxy.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/commands/loadxy.c b/commands/loadxy.c
index 7a91286..e023468 100644
--- a/commands/loadxy.c
+++ b/commands/loadxy.c
@@ -156,7 +156,7 @@ static int do_loadx(int argc, char *argv[])
char *output_file = NULL, *cname = NULL;
struct console_device *cdev = NULL;
- while ((opt = getopt(argc, argv, "f:b:o:c")) > 0) {
+ while ((opt = getopt(argc, argv, "f:b:t:o:c")) > 0) {
switch (opt) {
case 'f':
output_file = optarg;
@@ -211,12 +211,12 @@ static int do_loadx(int argc, char *argv[])
}
current_baudrate = console_change_speed(cdev, load_baudrate);
- printf("## Ready for binary (X-Modem) download "
+ printf("## Ready for binary (xmodem) download "
"to 0x%08lX offset on %s device at %d bps...\n", offset,
- output_file, load_baudrate);
- rcode = do_load_serial_ymodem(cdev);
+ output_file, load_baudrate ? load_baudrate : current_baudrate);
+ rcode = do_load_serial_xmodem(cdev, ofd);
if (rcode < 0) {
- printf("## Binary (kermit) download aborted (%d)\n", rcode);
+ printf("## Binary (xmodem) download aborted (%d)\n", rcode);
rcode = 1;
}
console_change_speed(cdev, current_baudrate);
--
1.7.9.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2014-05-08 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 20:36 Owen Kirby [this message]
2014-05-09 6:39 ` Sascha Hauer
2014-05-09 23:07 ` Owen Kirby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536BEABE.9060705@exegin.com \
--to=osk@exegin.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox