mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Owen Kirby <osk@exegin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Fix the options and protocols used by the loadx command.
Date: Fri, 09 May 2014 16:07:08 -0700	[thread overview]
Message-ID: <536D5F9C.9060807@exegin.com> (raw)
In-Reply-To: <20140509063923.GV5858@pengutronix.de>

On 14-05-08 11:39 PM, Sascha Hauer wrote:
> Hi Owen,
>
> On Thu, May 08, 2014 at 01:36:14PM -0700, Owen Kirby wrote:
>> From 3cd970250ff17ac406e46e18ebb26aa35949d1db Mon Sep 17 00:00:00 2001
>> From: Owen Kirby <osk@exegin.com>
>> Date: Thu, 8 May 2014 13:27:11 -0700
>> Subject: [PATCH] Fix the options and protocols used by the loadx command.
>>
>> It seems like the loadx command was improperly copy/pasted from the loady
>> implementation, and was trying to load files using the ymodem protocol. This
>> patch should fix the command so that it uses xmodem, implements the -t option
>> and outputs the correct baudrate being used.
>>
>> Signed-off-by: Owen Kirby <osk@exegin.com>
> I'm always surprised to still see patches to the serial download
> protocols. I hardly ever use them. Anyway, patch looks good, so:
> Applied, thanks
>
> Sascha
>
Old protocols never die :)

I'm not yet sure that I want to use xmodem over DFU just yet, but it
seemed like an obvious bug.

Cheers,
Owen

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-05-09 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 20:36 Owen Kirby
2014-05-09  6:39 ` Sascha Hauer
2014-05-09 23:07   ` Owen Kirby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536D5F9C.9060807@exegin.com \
    --to=osk@exegin.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox