mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Clément Léger" <clement.leger@kalray.eu>
To: Lucas Stach <l.stach@pengutronix.de>,
	Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC v3 1/5] PCI: initial commit
Date: Tue, 01 Jul 2014 09:29:23 +0200	[thread overview]
Message-ID: <53B26353.2040008@kalray.eu> (raw)
In-Reply-To: <1404123503.4305.16.camel@weser.hi.pengutronix.de>

> +int
> +pci_read_config_byte(struct pci_dev *dev, u8 where, u8 *val)
> +{
> +	return pci_bus_read_config_byte(dev->bus, dev->devfn, where, val);
> +}
> +
> +int
> +pci_read_config_word(struct pci_dev *dev, u8 where, u16 *val)
> +{
> +	return pci_bus_read_config_word(dev->bus, dev->devfn, where, val);
> +}
> +
> +int
> +pci_read_config_dword(struct pci_dev *dev, u8 where, u32 *val)
> +{
> +	return pci_bus_read_config_dword(dev->bus, dev->devfn, where, val);
> +}
> +
> +int
> +pci_write_config_byte(struct pci_dev *dev, u8 where, u8 val)
> +{
> +	return pci_bus_write_config_byte(dev->bus, dev->devfn, where, val);
> +}
> +
> +int
> +pci_write_config_word(struct pci_dev *dev, u8 where, u16 val)
> +{
> +	return pci_bus_write_config_word(dev->bus, dev->devfn, where, val);
> +}
> +
> +int
> +pci_write_config_dword(struct pci_dev *dev, u8 where, u32 val)
> +{
> +	return pci_bus_write_config_dword(dev->bus, dev->devfn, where, val);
> +}
>
I would suggest replacing the "u8 where" (in pci_read/write_config and 
others) by "int where" to allow future access to PCIe extended 
configuration space (up to offset 0x1000).

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-01  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 22:32 [RFC v3 0/5] barebox PCI support Antony Pavlov
2014-06-25 22:32 ` [RFC v3 1/5] PCI: initial commit Antony Pavlov
2014-06-30 10:18   ` Lucas Stach
2014-07-01  7:29     ` Clément Léger [this message]
2014-07-01  7:48       ` Antony Pavlov
2014-06-25 22:32 ` [RFC v3 2/5] commands: add 'lspci' command Antony Pavlov
2014-06-30 10:21   ` Lucas Stach
2014-06-30 17:32     ` Antony Pavlov
2014-06-25 22:32 ` [RFC v3 3/5] net: add RealTek RTL-8139 PCI Ethernet driver Antony Pavlov
2014-06-25 22:32 ` [RFC v3 4/5] MIPS: add PCI support for GT64120-based Malta board Antony Pavlov
2014-06-25 22:32 ` [RFC v3 5/5] MIPS: qemu-malta_defconfig: enable PCI & network stuff Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B26353.2040008@kalray.eu \
    --to=clement.leger@kalray.eu \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox