[RFC] led: try to get LED's label from the 'label' property

[RFC] led: try to get LED's label from the 'label' property

[Antony Pavlov]

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/led/led-gpio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
index 7bb3b49..31ae627 100644
--- a/drivers/led/led-gpio.c
+++ b/drivers/led/led-gpio.c
@@ -212,7 +212,9 @@ static int led_gpio_of_probe(struct device_d *dev)
 			continue;
 
 		gled = xzalloc(sizeof(*gled));
-		gled->led.name = xstrdup(child->name);
+		gled->led.name = of_get_property(child, "label", NULL);
+		if (!gled->led.name)
+			gled->led.name = xstrdup(child->name);
 		gled->gpio = gpio;
 		gled->active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
 
-- 
2.0.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC] led: try to get LED's label from the 'label' property

[Sebastian Hesselbarth]

On 07/26/2014 02:11 AM, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  drivers/led/led-gpio.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> index 7bb3b49..31ae627 100644
> --- a/drivers/led/led-gpio.c
> +++ b/drivers/led/led-gpio.c
> @@ -212,7 +212,9 @@ static int led_gpio_of_probe(struct device_d *dev)
>  			continue;
>  
>  		gled = xzalloc(sizeof(*gled));
> -		gled->led.name = xstrdup(child->name);
> +		gled->led.name = of_get_property(child, "label", NULL);

IIRC, back the days this was introduced, there was no "label" property.

Anyway, of_get_property gives you the reference to something that can
change, i.e. if you remove/modify the corresponding node or property
you'll end up with a gleg->led.name pointing to something old or gone.

Sebastian

> +		if (!gled->led.name)
> +			gled->led.name = xstrdup(child->name);
>  		gled->gpio = gpio;
>  		gled->active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
>  
> 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC] led: try to get LED's label from the 'label' property

[Antony Pavlov]

On Sat, 26 Jul 2014 10:19:57 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> On 07/26/2014 02:11 AM, Antony Pavlov wrote:
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> >  drivers/led/led-gpio.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> > index 7bb3b49..31ae627 100644
> > --- a/drivers/led/led-gpio.c
> > +++ b/drivers/led/led-gpio.c
> > @@ -212,7 +212,9 @@ static int led_gpio_of_probe(struct device_d *dev)
> >  			continue;
> >  
> >  		gled = xzalloc(sizeof(*gled));
> > -		gled->led.name = xstrdup(child->name);
> > +		gled->led.name = of_get_property(child, "label", NULL);
> 
> IIRC, back the days this was introduced, there was no "label" property.

Do you mean "the days barebox.git/drivers/led/led-gpio.c was introduced"?

commit 91d781f51df5d4de23d09a6777bfc968a0a7ca68
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Sat Dec 18 14:36:02 2010 +0100

    LED: Add gpio LED support

But linux.git/drivers/leds/leds-gpio.c was introduce in 

commit a7d878af94b223013a48078e0c8c0a654c24a057
Author: Trent Piepho <tpiepho@freescale.com>
Date:   Sat Jan 10 17:26:01 2009 +0000

    leds: Add openfirmware platform device support

> Anyway, of_get_property gives you the reference to something that can
> change, i.e. if you remove/modify the corresponding node or property
> you'll end up with a gleg->led.name pointing to something old or gone.
> 
> Sebastian
> 
> > +		if (!gled->led.name)
> > +			gled->led.name = xstrdup(child->name);
> >  		gled->gpio = gpio;
> >  		gled->active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
> >  
> > 
> 


-- 
-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox