mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	barebox@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Jason Cooper <jason@lakedaemon.net>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 4/6] net: phy: Support Marvell 88EE1545 PHY
Date: Thu, 31 Jul 2014 19:25:45 +0200	[thread overview]
Message-ID: <53DA7C19.7000108@gmail.com> (raw)
In-Reply-To: <20140729213734.GA27654@arch.cereza>

On 29.07.2014 23:37, Ezequiel Garcia wrote:
> On 29 Jul 05:44 PM, Ezequiel Garcia wrote:
>> This commit adds support for Marvell's 88E1545 PHY chip. In particular, this
>> allows to support QSGMII interfaces.
>>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> ---
>>   drivers/net/phy/marvell.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>
>> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
>> index 34f852e..ad8854d 100644
>> --- a/drivers/net/phy/marvell.c
>> +++ b/drivers/net/phy/marvell.c
>> @@ -23,6 +23,7 @@
>>   #define MARVELL_PHY_ID_88E1318S		0x01410e90
>>   #define MARVELL_PHY_ID_88E1116R		0x01410e40
>>   #define MARVELL_PHY_ID_88E1510		0x01410dd0
>> +#define MARVELL_PHY_ID_88E154x		0x01410eb1
>>
>>   /* Mask used for ID comparisons */
>>   #define MARVELL_PHY_ID_MASK		0xfffffff0
>
> Small erratum: given this mask, the ID for the new PHY device should be
> 0x0x01410eb0 instead of 0x01410eb1.
>
> And by the way, Mirabox and Openblocks AX3 network support is not working.
> The link is not detected, so it seems there's some more PHY work to be done.

I just confirmed that (after adding support for 88e1318), driver works
on Armada XP ix4-300d on both RGMII ports.

Armada XP requires some additional magic foo in some retarded register
to enable RGMII:

#define ARMADA_XP_PUP_ENABLE_BASE	(ARMADA_370_XP_INT_REGS_BASE + 0x1864c)
/* Enable GBE0, GBE1, LCD and NFC PUP */
reg = readl(ARMADA_XP_PUP_ENABLE_BASE);
reg |= 0x17;
writel(reg, ARMADA_XP_PUP_ENABLE_BASE);

I am not yet sure if that is also true for Armada 370 nor if it is also
true for SGMII/QSGMII ports. Took me a while to hunt this down, but
without above foo, there is no txclk on RGMII.

Sebastian

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-31 17:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 20:44 [PATCH 0/6] Add network support for Armada 370/XP Ezequiel Garcia
2014-07-29 20:44 ` [PATCH 1/6] net: phy: Add fallbacks for the obsoletes phy DT properties Ezequiel Garcia
2014-07-29 20:44 ` [PATCH 2/6] net: phy: mdio-mvebu: Make the clock property required Ezequiel Garcia
2014-07-29 20:44 ` [PATCH 3/6] net: phy: Add minimal support for QSGMII PHY Ezequiel Garcia
2014-07-29 20:44 ` [PATCH 4/6] net: phy: Support Marvell 88EE1545 PHY Ezequiel Garcia
2014-07-29 21:37   ` Ezequiel Garcia
2014-07-31 17:25     ` Sebastian Hesselbarth [this message]
2014-08-02 17:40       ` Ezequiel Garcia
2014-08-02 17:48         ` Sebastian Hesselbarth
2014-08-02 20:33           ` Ezequiel Garcia
2014-07-29 20:45 ` [PATCH 5/6] net: Add driver for Armada 370/XP 10/100/1000 Mbps network controller Ezequiel Garcia
2014-07-31  5:42   ` Sascha Hauer
2014-07-31 13:43     ` Ezequiel Garcia
2014-07-29 20:45 ` [PATCH 6/6] configs: Add network options to Armada 370/XP boards Ezequiel Garcia
2014-07-31  5:49 ` [PATCH 0/6] Add network support for Armada 370/XP Sascha Hauer
2014-08-02 17:41   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA7C19.7000108@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox