From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XCu7F-0005IH-Se for barebox@lists.infradead.org; Thu, 31 Jul 2014 17:26:11 +0000 Received: by mail-wi0-f170.google.com with SMTP id f8so1623275wiw.1 for ; Thu, 31 Jul 2014 10:25:47 -0700 (PDT) Message-ID: <53DA7C19.7000108@gmail.com> Date: Thu, 31 Jul 2014 19:25:45 +0200 From: Sebastian Hesselbarth References: <1406666701-15356-1-git-send-email-ezequiel.garcia@free-electrons.com> <1406666701-15356-5-git-send-email-ezequiel.garcia@free-electrons.com> <20140729213734.GA27654@arch.cereza> In-Reply-To: <20140729213734.GA27654@arch.cereza> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/6] net: phy: Support Marvell 88EE1545 PHY To: Ezequiel Garcia , barebox@lists.infradead.org Cc: Thomas Petazzoni , Jason Cooper , Willy Tarreau On 29.07.2014 23:37, Ezequiel Garcia wrote: > On 29 Jul 05:44 PM, Ezequiel Garcia wrote: >> This commit adds support for Marvell's 88E1545 PHY chip. In particular, this >> allows to support QSGMII interfaces. >> >> Signed-off-by: Ezequiel Garcia >> --- >> drivers/net/phy/marvell.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> >> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c >> index 34f852e..ad8854d 100644 >> --- a/drivers/net/phy/marvell.c >> +++ b/drivers/net/phy/marvell.c >> @@ -23,6 +23,7 @@ >> #define MARVELL_PHY_ID_88E1318S 0x01410e90 >> #define MARVELL_PHY_ID_88E1116R 0x01410e40 >> #define MARVELL_PHY_ID_88E1510 0x01410dd0 >> +#define MARVELL_PHY_ID_88E154x 0x01410eb1 >> >> /* Mask used for ID comparisons */ >> #define MARVELL_PHY_ID_MASK 0xfffffff0 > > Small erratum: given this mask, the ID for the new PHY device should be > 0x0x01410eb0 instead of 0x01410eb1. > > And by the way, Mirabox and Openblocks AX3 network support is not working. > The link is not detected, so it seems there's some more PHY work to be done. I just confirmed that (after adding support for 88e1318), driver works on Armada XP ix4-300d on both RGMII ports. Armada XP requires some additional magic foo in some retarded register to enable RGMII: #define ARMADA_XP_PUP_ENABLE_BASE (ARMADA_370_XP_INT_REGS_BASE + 0x1864c) /* Enable GBE0, GBE1, LCD and NFC PUP */ reg = readl(ARMADA_XP_PUP_ENABLE_BASE); reg |= 0x17; writel(reg, ARMADA_XP_PUP_ENABLE_BASE); I am not yet sure if that is also true for Armada 370 nor if it is also true for SGMII/QSGMII ports. Took me a while to hunt this down, but without above foo, there is no txclk on RGMII. Sebastian _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox