mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: mvebu: Allow multiple SoCs
Date: Mon, 15 Sep 2014 10:00:40 +0200	[thread overview]
Message-ID: <54169CA8.5030003@gmail.com> (raw)
In-Reply-To: <1410766873-4393-5-git-send-email-s.hauer@pengutronix.de>

On 09/15/2014 09:41 AM, Sascha Hauer wrote:
> Now that the correct SoC specific memory fixup function is called
> we can allow to select multiple SoCs in Kconfig.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha,

thanks for the patches, I'll give them a try later. FWIW, this
patch allows to build Kirkwood together with Dove and Armada ones,
which will not work at all. Kirkwood is armv5, while the others
are armv7. There is no way you run a multiv7 barebox on kirkwood,
right?

Sebastian

> ---
>   arch/arm/mach-mvebu/Kconfig | 38 ++++++++++++--------------------------
>   1 file changed, 12 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 3270f92..c5e6b59 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -7,87 +7,73 @@ config ARCH_TEXT_BASE
>   	default 0x2000000 if ARCH_DOVE
>   	default 0x2000000 if ARCH_KIRKWOOD
>
> -choice
> -	prompt "Marvell EBU Processor"
> -
>   config ARCH_ARMADA_370
> -	bool "Armada 370"
> +	bool
>   	select CPU_V7
>   	select CLOCKSOURCE_MVEBU
>   	select PINCTRL_ARMADA_370
>
>   config ARCH_ARMADA_XP
> -	bool "Armada XP"
> +	bool
>   	select CPU_V7
>   	select CLOCKSOURCE_MVEBU
>   	select PINCTRL_ARMADA_XP
>
>   config ARCH_DOVE
> -	bool "Dove 88AP510"
> +	bool
>   	select CPU_V7
>   	select CLOCKSOURCE_ORION
>   	select PINCTRL_DOVE
>
>   config ARCH_KIRKWOOD
> -	bool "Kirkwood"
> +	bool
>   	select CPU_FEROCEON
>   	select CLOCKSOURCE_ORION
>   	select PINCTRL_KIRKWOOD
>
> -endchoice
> -
>   #
>   # Armada 370 SoC boards
>   #
> -
> -if ARCH_ARMADA_370
> -
> +#
>   config MACH_GLOBALSCALE_MIRABOX
>   	bool "Globalscale Mirabox"
> -
> -endif # ARCH_ARMADA_370
> +	select ARCH_ARMADA_370
>
>   #
>   # Armada XP SoC boards
>   #
>
> -if ARCH_ARMADA_XP
> -
>   config MACH_PLATHOME_OPENBLOCKS_AX3
>   	bool "PlatHome OpenBlocks AX3"
> +	select ARCH_ARMADA_XP
>
>   config MACH_MARVELL_ARMADA_XP_GP
>   	bool "Marvell Armada XP GP"
> -
> -endif # ARCH_ARMADA_XP
> +	select ARCH_ARMADA_XP
>
>   #
>   # Dove 88AP510 SoC boards
>   #
>
> -if ARCH_DOVE
> -
>   config MACH_SOLIDRUN_CUBOX
>   	bool "SolidRun CuBox"
> -
> -endif # ARCH_DOVE
> +	select ARCH_DOVE
>
>   #
>   # Kirkwood SoC boards
>   #
>
> -if ARCH_KIRKWOOD
> -
>   config MACH_GLOBALSCALE_GURUPLUG
>   	bool "Guruplug"
> +	select ARCH_KIRKWOOD
>
>   config MACH_PLATHOME_OPENBLOCKS_A6
>   	bool "PlatHome OpenBlocks A6"
> +	select ARCH_KIRKWOOD
>
>   config MACH_USI_TOPKICK
>   	bool "Topkick"
> -
> -endif # ARCH_KIRKWOOD
> +	select ARCH_KIRKWOOD
>
>   #
>   # Common options
>


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-09-15  8:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  7:41 mvebu multi SoC support Sascha Hauer
2014-09-15  7:41 ` [PATCH 1/5] ARM: mvebu: Add common reset_cpu function Sascha Hauer
2014-09-16 19:17   ` Sebastian Hesselbarth
2014-09-17  6:32     ` Sascha Hauer
2014-09-15  7:41 ` [PATCH 2/5] ARM: mvebu: Simplify memory init order Sascha Hauer
2014-09-16 20:05   ` Sebastian Hesselbarth
2014-09-17  6:45     ` Sascha Hauer
2014-09-17  7:19       ` Sebastian Hesselbarth
2014-09-17  7:29         ` Sascha Hauer
2014-09-15  7:41 ` [PATCH 3/5] ARM: mvebu: Check for correct SoC in of_fixup callback Sascha Hauer
2014-09-15  7:41 ` [PATCH 4/5] ARM: mvebu: Allow multiple SoCs Sascha Hauer
2014-09-15  8:00   ` Sebastian Hesselbarth [this message]
2014-09-15  9:13     ` Sascha Hauer
2014-09-15 21:12       ` Sebastian Hesselbarth
2014-09-16  6:00         ` Sascha Hauer
2014-09-15  7:41 ` [PATCH 5/5] ARM: Add mvebu_defconfig Sascha Hauer
2014-09-15 21:15   ` Sebastian Hesselbarth
2014-09-16  6:05     ` Sascha Hauer
2014-09-15  8:09 ` mvebu multi SoC support Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54169CA8.5030003@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox