From: Bo Shen <voice.shen@atmel.com>
To: "Raphaël Poggi" <raphio98@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 8/9] ARM: at91: add sama5d4 soc support #2
Date: Thu, 18 Sep 2014 09:43:18 +0800 [thread overview]
Message-ID: <541A38B6.7000204@atmel.com> (raw)
In-Reply-To: <20140913201231.GB22947@gmail.com>
Hi Raphaël Poggi,
On 09/14/2014 04:12 AM, Raphaël Poggi wrote:
>> +static struct clk_lookup periph_clocks_lookups[] = {
>> >+ CLKDEV_CON_DEV_ID("macb_clk", "macb0", &macb0_clk),
>> >+ CLKDEV_CON_DEV_ID("mci_clk", "atmel_mci0", &mmc0_clk),
>> >+ CLKDEV_CON_DEV_ID("mci_clk", "atmel_mci1", &mmc1_clk),
>> >+ CLKDEV_CON_DEV_ID("spi_clk", "atmel_spi0", &spi0_clk),
>> >+ CLKDEV_DEV_ID("at91sam9x5-gpio0", &pioA_clk),
>> >+ CLKDEV_DEV_ID("at91sam9x5-gpio1", &pioB_clk),
>> >+ CLKDEV_DEV_ID("at91sam9x5-gpio2", &pioC_clk),
>> >+ CLKDEV_DEV_ID("at91sam9x5-gpio3", &pioD_clk),
>> >+ CLKDEV_DEV_ID("at91sam9x5-gpio4", &pioE_clk),
> Why not using clkdev_add_physbase for the gpio clocks ?
> This allow to use these clocks in device tree and non device context.
Thanks for remind this. I will fix it in v2.
>> +#else
>> >+void at91_add_device_i2c(short i2c_id, struct i2c_board_info *devices,
>> >+ int nr_devices) {}
>> >+#endif
> Maybe we can use the new atmel i2c driver, no ?
Yes, we can. However, I think use the GPIO i2c first, after the i2c fix
has been applied, then switch to use atmel i2c driver. In this way, it
won't block the sama5d4ek board support go into mainline.
Btw, if the i2c fix has been applied before I send the v2 patch, I will
switch to use atmel i2c driver.
Best Regards,
Bo Shen
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-09-18 1:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 10:21 [PATCH 0/9] ARM: at91: add sama5d4ek board support Bo Shen
2014-09-17 10:21 ` [PATCH 1/9] ARM: at91: move pmc base address into soc header Bo Shen
2014-09-17 10:21 ` [PATCH 2/9] ARM: atmel: sama5d3 is a family member of sama5 Bo Shen
2014-09-17 10:21 ` [PATCH 3/9] ARM: at91: clock: use cpu_has_pcr for pcr1 checking Bo Shen
2014-09-17 10:21 ` [PATCH 4/9] nand: atmel: runtime to generate galois table Bo Shen
2014-09-17 10:21 ` [PATCH 5/9] net: macb: using default value for FBLDO Bo Shen
2014-09-22 4:59 ` Sascha Hauer
2014-09-22 5:08 ` Bo Shen
2014-09-17 10:21 ` [PATCH 6/9] mci: atmel: add new ip version 0x600 support Bo Shen
2014-09-17 10:21 ` [PATCH 7/9] ARM: at91: add sama5d4 soc support #1 Bo Shen
2014-09-18 6:10 ` Sascha Hauer
2014-09-23 3:02 ` Bo Shen
2014-09-23 7:54 ` Sascha Hauer
2014-09-17 10:21 ` [PATCH 8/9] ARM: at91: add sama5d4 soc support #2 Bo Shen
2014-09-13 20:12 ` Raphaël Poggi
2014-09-18 1:43 ` Bo Shen [this message]
2014-09-17 10:21 ` [PATCH 9/9] ARM: at91: add sama5d4ek board support Bo Shen
2014-09-22 5:02 ` [PATCH 0/9] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A38B6.7000204@atmel.com \
--to=voice.shen@atmel.com \
--cc=barebox@lists.infradead.org \
--cc=raphio98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox