From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 29 Jun 2026 11:06:35 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1we7wp-00B49o-2U for lore@lore.pengutronix.de; Mon, 29 Jun 2026 11:06:35 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1we7wp-0005BE-3F for lore@pengutronix.de; Mon, 29 Jun 2026 11:06:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vvtoj22OU4SsXPqe+08m/62vABjCJcb43C5rTN6vmz4=; b=pB1CYekGjuSxeBL9Ju0wPN9yF1 A7EvwROqVn9wg6lAr6uQPsYWhdKzqpbXh4Z6gaAxDLOkJc4P3+/ktGM24PKcIr32SakAnvVDuBfeh 6avzsQI4ghfkoYyg1s8Beg+TzVHzp8ZvL69wa82FKs66DIyIMRQtKDhTfYmJIr4Ta90uXg/YCNAKI XEhZy7t2Hzn2O/leyj2evLEjm6jJiLjWJaRVnmtm9hp7Dg18VTNH4BZZkrT52+WH4Kx0aC6bKPKJh 9WDAFVyrFaXaDLdaAIwFywMonZ7qu6dJV9NzeC24jwLDR6Ek4dW4MwHbrO2qzNLMtrCslziA8lsrf Ivicl8Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1we7vo-0000000E6A9-25wX; Mon, 29 Jun 2026 09:05:32 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1we7vm-0000000E69b-1hSI for barebox@lists.infradead.org; Mon, 29 Jun 2026 09:05:31 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1we7vk-00043c-OZ; Mon, 29 Jun 2026 11:05:28 +0200 Message-ID: <548b8b37-146b-48c7-b495-b74a8425410c@barebox.org> Date: Mon, 29 Jun 2026 11:05:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: barebox@lists.infradead.org References: Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260629_020530_446137_C409CDAF X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 7/9] mci: add PCI SDHCI controller support X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi, On 6/29/26 11:04 AM, Sascha Hauer wrote: > On 2026-06-29 10:51, Ahmad Fatoum wrote: >> Hello Sascha, >> >> On 6/29/26 10:47 AM, Sascha Hauer wrote: >>> On 2026-06-26 18:19, Ahmad Fatoum wrote: >>>> QEMU can expose eMMC through the class-compliant sdhci-pci device, but >>>> barebox only had platform SDHCI glue. Add a PCI host driver that maps BAR0, >>>> enables bus mastering, initializes the SDHCI core and registers an MCI host. >>>> >>>> This is intentionally small and PIO-based, which is enough for the QEMU RPMB >>>> test environment while reusing the common SDHCI helpers. >>> >>> Is this comment wrong? The driver depends on HAS_DMA and even calls >>> sdhci_setup_adma(). >> >> Yes, I had problems getting RPMB access to work with PIO and ADMA fixed >> that and I had not dug deeper. >> >> Can you remove that paragraph when applying? >>>> index 4413fd1655aa..d6746fbec28f 100644 >>>> --- a/drivers/mci/mci-core.c >>>> +++ b/drivers/mci/mci-core.c >>>> @@ -2942,7 +2942,7 @@ static struct device_node *mci_get_partition_node(struct device_node *hwnode, >>>> struct device_node *np; >>>> char partnodename[sizeof("bootx-partitions")]; >>>> >>>> - if (index > 8) >>>> + if (!hwnode || index > 8) >>>> return NULL; >>> >>> Should this be an extra patch? >> >> This is the first non-DT instantiated device and thus there is no DT >> node. I can split this off if you like. The rest of the file seems to >> handle non-existence of a DT node just fine. > > Back in the old days non-DT instantiated devices were the normal case, > so 15cc1fa00c ("mci: parse upstream boot/gp partition binding") might > have introduced a regression, so I would prefer to have this as a > separate patch. Fair enough. Should I resend all or just this patch? Cheers, Ahmad > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >