mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>, barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: add pxa3xx-nand driver
Date: Sun, 04 Jan 2015 15:50:55 -0300	[thread overview]
Message-ID: <54A98B8F.2040405@free-electrons.com> (raw)
In-Reply-To: <1420149516-29457-1-git-send-email-robert.jarzmik@free.fr>

Hi Robert,

On 01/01/2015 06:58 PM, Robert Jarzmik wrote:
> The driver is taken from the Linux kernel, with the following changes :
>  - all DMA removed
>  - all asynchronous handling removed, including the interrupt handler,
>    and the asynchronous state handling
>  - pxa armada support removed
> 

If my memory doesn't fail me, the NAND controller is called NFC v1 on
pxa3xx, and NFC v2 on mvebu SoCs.

I'm wondering if we can pick a better name for this driver in barebox.
Maybe something like 'mv_nfc_nand' ?

Also, I think you can get rid of the 'builtin_flash_types' struct and
all the device detection routines, which are really duplicating the
MTD's lower level job.

I never removed it from the Linux driver, because I was afraid of
regressions and there are little testers around. However, on Barebox we
can benefit from removing that, and starting with a cleaner driver.

Just my two cents,
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-01-04 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01 21:58 Robert Jarzmik
2015-01-04 18:50 ` Ezequiel Garcia [this message]
2015-01-05 10:44   ` robert.jarzmik
2015-01-05 12:03     ` Sascha Hauer
2015-01-05 20:32       ` Robert Jarzmik
2015-01-05 20:33         ` Ezequiel Garcia
2015-01-05 22:42           ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A98B8F.2040405@free-electrons.com \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=barebox@lists.infradead.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox