Re: [PATCH] ARM: atmel: sama5d3xek: let gmac auto detect phy id

[Bo Shen <voice.shen@atmel.com>]

Hi J,

On 01/22/2015 12:35 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
>> On Jan 21, 2015, at 11:07 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>>
>> On Mon, Jan 19, 2015 at 12:39:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 17:54 Mon 19 Jan     , Bo Shen wrote:
>>>> On the SAMA5D33 and SAMA5D35 the GMAC PHY ID is 1 while not 7.
>>>> So, let the GMAC auto detect phy id, or else hard code to 7,
>>>> it can not work on these two boards.
>>>>
>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>>> ---
>>>>
>>>> arch/arm/boards/sama5d3xek/init.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boards/sama5d3xek/init.c b/arch/arm/boards/sama5d3xek/init.c
>>>> index 49d2b37..0b83147 100644
>>>> --- a/arch/arm/boards/sama5d3xek/init.c
>>>> +++ b/arch/arm/boards/sama5d3xek/init.c
>>>> @@ -123,7 +123,7 @@ static void ek_add_device_nand(void) {}
>>>> #if defined(CONFIG_DRIVER_NET_MACB)
>>>> static struct macb_platform_data gmac_pdata = {
>>>> 	.phy_interface = PHY_INTERFACE_MODE_RGMII,
>>>> -	.phy_addr = 7,
>>>> +	.phy_addr = -1,
>>> IIRC the auto detect do not work on all board
>>> NACK
>>
>> Please give us some more information why this doesn't work or on which
>> boards this doesn't work. Rejecting patches with 'IIRC' just blocks the
>> patch without giving a clue what else should be done.
>
> This is the same board but différent SoC Module
>
> Bo MUST test it on all of them before do such modification

Yes, I do this kind of test.

> IIRC the phy is detect on addr 1 instead of 7 on some CPU Module

Yes, as the commit message specified, the phy address of SAMA5D33 and 
SAMA5D35 are 1. So, let the GMAC to auto detect the phy address, or else 
using the hard coded phy address 7, then the network won't work on 
SAMA5D33 and SAMA5D35 module.

> Best Regards,
> J.
>>
>> Sascha
>>
>> --
>> Pengutronix e.K.                           |                             |
>> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
>> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>

Best Regards,
Bo Shen

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox