From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.phycard.de ([217.6.246.34] helo=root.phytec.de) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YLpgu-0005JO-JA for barebox@lists.infradead.org; Thu, 12 Feb 2015 09:04:10 +0000 Message-ID: <54DC6C6F.5020809@phytec.de> Date: Thu, 12 Feb 2015 10:03:43 +0100 From: Wadim Egorov MIME-Version: 1.0 References: <1423577638-27907-1-git-send-email-w.egorov@phytec.de> <1423577638-27907-2-git-send-email-w.egorov@phytec.de> <20150211073910.GF12209@pengutronix.de> <54DB279E.7070806@phytec.de> <20150212083029.GP12209@pengutronix.de> In-Reply-To: <20150212083029.GP12209@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v3: For next 2/2] ARM: am33xx: Add support for reset reason detection To: Sascha Hauer Cc: barebox@lists.infradead.org On 12.02.2015 09:30, Sascha Hauer wrote: > On Wed, Feb 11, 2015 at 10:57:50AM +0100, Wadim Egorov wrote: >> On 11.02.2015 08:39, Sascha Hauer wrote: >>> On Tue, Feb 10, 2015 at 03:13:58PM +0100, Wadim Egorov wrote: >>>> Also activate in defconfig. >>>> >>>> Signed-off-by: Wadim Egorov >>>> + break; >>>> + case (1 << 1): >>>> + reset_source_set(RESET_RST); >>>> + break; >>>> + case (1 << 0): >>>> + reset_source_set(RESET_POR); >>>> + break; >>>> + default: >>>> + reset_source_set(RESET_UKWN); >>>> + break; >>>> + } >>>> + >>>> + return 0; >>>> +} >>>> +device_initcall(am33xx_detect_reset_reason); >>> No SoC specific initcall without testing if you're running on the >>> correct SoC please. Better call it from am33xx_init() which is only >>> executed on am33xx. >>> >>> Sascha >> Calling it from am33xx_init() was also my idea in the first place. >> AFAIK you have to call reset_source_set() after coredevice_initcall(). >> So it is not possible to call it from am33xx_init(). > Could you try this patch? It shoud resolve this issue. > > Sascha It works with your changes. I will send a v4 later. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox