* [PATCH 1/3] fixup! sandbox: hostfile: completely switch to OF based probing
2015-03-05 14:36 [PATCH 0/3] sandbox cleanups Marc Kleine-Budde
@ 2015-03-05 14:36 ` Marc Kleine-Budde
2015-03-05 14:36 ` [PATCH 2/3] " Marc Kleine-Budde
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Marc Kleine-Budde @ 2015-03-05 14:36 UTC (permalink / raw)
To: barebox
It makes no sense to put an address-cells and size-cells property in the
hostfile, as it will only affect sub-nodes.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
arch/sandbox/board/hostfile.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c
index c6fd80fd8761..41ded73a3a21 100644
--- a/arch/sandbox/board/hostfile.c
+++ b/arch/sandbox/board/hostfile.c
@@ -140,14 +140,6 @@ static int of_hostfile_fixup(struct device_node *root, void *ctx)
if (ret)
return ret;
- ret = of_property_write_u32(node, "#address-cells", 2);
- if (ret)
- return ret;
-
- ret = of_property_write_u32(node, "#size-cells", 1);
- if (ret)
- return ret;
-
ret = of_set_property(node, "compatible", hostfile_dt_ids->compatible,
strlen(hostfile_dt_ids->compatible) + 1, 1);
if (ret)
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 2/3] fixup! sandbox: hostfile: completely switch to OF based probing
2015-03-05 14:36 [PATCH 0/3] sandbox cleanups Marc Kleine-Budde
2015-03-05 14:36 ` [PATCH 1/3] fixup! sandbox: hostfile: completely switch to OF based probing Marc Kleine-Budde
@ 2015-03-05 14:36 ` Marc Kleine-Budde
2015-03-05 14:36 ` [PATCH 3/3] fixup! sandbox: add support to pass dtb to barebox Marc Kleine-Budde
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Marc Kleine-Budde @ 2015-03-05 14:36 UTC (permalink / raw)
To: barebox
hostfile: add "barebox" prefix to properties
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
arch/sandbox/board/hostfile.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/sandbox/board/hostfile.c b/arch/sandbox/board/hostfile.c
index 41ded73a3a21..c1a2643bc7ff 100644
--- a/arch/sandbox/board/hostfile.c
+++ b/arch/sandbox/board/hostfile.c
@@ -85,11 +85,12 @@ static int hf_probe(struct device_d *dev)
if (!dev->device_node)
return -ENODEV;
- err = of_property_read_u32(dev->device_node, "fd", &priv->fd);
+ err = of_property_read_u32(dev->device_node, "barebox,fd", &priv->fd);
if (err)
return err;
- err = of_property_read_string(dev->device_node, "filename", &priv->filename);
+ err = of_property_read_string(dev->device_node, "barebox,filename",
+ &priv->filename);
if (err)
return err;
@@ -132,7 +133,8 @@ static int of_hostfile_fixup(struct device_node *root, void *ctx)
node = of_new_node(root, hf->devname);
- ret = of_property_write_u32(node, "fd", hf->fd);
+ ret = of_set_property(node, "compatible", hostfile_dt_ids->compatible,
+ strlen(hostfile_dt_ids->compatible) + 1, 1);
if (ret)
return ret;
@@ -140,12 +142,11 @@ static int of_hostfile_fixup(struct device_node *root, void *ctx)
if (ret)
return ret;
- ret = of_set_property(node, "compatible", hostfile_dt_ids->compatible,
- strlen(hostfile_dt_ids->compatible) + 1, 1);
+ ret = of_property_write_u32(node, "barebox,fd", hf->fd);
if (ret)
return ret;
- ret = of_set_property(node, "filename", hf->filename,
+ ret = of_set_property(node, "barebox,filename", hf->filename,
strlen(hf->filename) + 1, 1);
return ret;
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 3/3] fixup! sandbox: add support to pass dtb to barebox
2015-03-05 14:36 [PATCH 0/3] sandbox cleanups Marc Kleine-Budde
2015-03-05 14:36 ` [PATCH 1/3] fixup! sandbox: hostfile: completely switch to OF based probing Marc Kleine-Budde
2015-03-05 14:36 ` [PATCH 2/3] " Marc Kleine-Budde
@ 2015-03-05 14:36 ` Marc Kleine-Budde
2015-03-06 6:42 ` [PATCH 0/3] sandbox cleanups Sascha Hauer
2015-03-10 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
4 siblings, 0 replies; 12+ messages in thread
From: Marc Kleine-Budde @ 2015-03-05 14:36 UTC (permalink / raw)
To: barebox
This patch will generate a oftree on the fly, if no dtb is specified on the cmd
line.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
arch/sandbox/board/dtb.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/arch/sandbox/board/dtb.c b/arch/sandbox/board/dtb.c
index 9d4210164e01..708eca903a38 100644
--- a/arch/sandbox/board/dtb.c
+++ b/arch/sandbox/board/dtb.c
@@ -38,15 +38,25 @@ int barebox_register_dtb(const void *new_dtb)
static int of_sandbox_init(void)
{
struct device_node *root;
+ int ret;
- if (!dtb)
- return 0;
+ if (dtb) {
+ root = of_unflatten_dtb(dtb);
+ } else {
+ root = of_new_node(NULL, NULL);
+
+ ret = of_property_write_u32(root, "#address-cells", 2);
+ if (ret)
+ return ret;
- root = of_unflatten_dtb(dtb);
- if (IS_ERR(root)) {
- return PTR_ERR(root);
+ ret = of_property_write_u32(root, "#size-cells", 1);
+ if (ret)
+ return ret;
}
+ if (IS_ERR(root))
+ return PTR_ERR(root);
+
of_set_root_node(root);
of_fix_tree(root);
if (IS_ENABLED(CONFIG_OFDEVICE))
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] sandbox cleanups
2015-03-05 14:36 [PATCH 0/3] sandbox cleanups Marc Kleine-Budde
` (2 preceding siblings ...)
2015-03-05 14:36 ` [PATCH 3/3] fixup! sandbox: add support to pass dtb to barebox Marc Kleine-Budde
@ 2015-03-06 6:42 ` Sascha Hauer
2015-03-10 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
4 siblings, 0 replies; 12+ messages in thread
From: Sascha Hauer @ 2015-03-06 6:42 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: barebox
On Thu, Mar 05, 2015 at 03:36:38PM +0100, Marc Kleine-Budde wrote:
> Hey Sascha,
>
> three patches for next, please fixup into the for-next/sandbox-of banch.
>
> Two patches cleanup the hostfile handling, while the third one will generate a
> device tree of the fly, if no one is specified on the sandbox command line.
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] sandbox cleanups
2015-03-05 14:36 [PATCH 0/3] sandbox cleanups Marc Kleine-Budde
` (3 preceding siblings ...)
2015-03-06 6:42 ` [PATCH 0/3] sandbox cleanups Sascha Hauer
@ 2015-03-10 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-10 14:26 ` Marc Kleine-Budde
2015-03-10 14:32 ` Marc Kleine-Budde
4 siblings, 2 replies; 12+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2015-03-10 14:24 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: barebox
On 15:36 Thu 05 Mar , Marc Kleine-Budde wrote:
> Hey Sascha,
>
> three patches for next, please fixup into the for-next/sandbox-of banch.
I test the new sanbox on next
when you pass -i the file is not present in the /dev now
I'm working on secure boot and I use sandbox & qemu to test it
can we fix it asap please TOO busy to dig into it
Best Regards,
J.
>
> Two patches cleanup the hostfile handling, while the third one will generate a
> device tree of the fly, if no one is specified on the sandbox command line.
>
> Marc
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] sandbox cleanups
2015-03-10 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2015-03-10 14:26 ` Marc Kleine-Budde
2015-03-10 14:52 ` Marc Kleine-Budde
2015-03-10 14:32 ` Marc Kleine-Budde
1 sibling, 1 reply; 12+ messages in thread
From: Marc Kleine-Budde @ 2015-03-10 14:26 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]
On 03/10/2015 03:24 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 15:36 Thu 05 Mar , Marc Kleine-Budde wrote:
>> Hey Sascha,
>>
>> three patches for next, please fixup into the for-next/sandbox-of banch.
>
> I test the new sanbox on next
>
> when you pass -i the file is not present in the /dev now
>
> I'm working on secure boot and I use sandbox & qemu to test it
>
> can we fix it asap please TOO busy to dig into it
Can you apply there three patches and check if the problem is solved?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] sandbox cleanups
2015-03-10 14:24 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-10 14:26 ` Marc Kleine-Budde
@ 2015-03-10 14:32 ` Marc Kleine-Budde
2015-03-10 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 12+ messages in thread
From: Marc Kleine-Budde @ 2015-03-10 14:32 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]
On 03/10/2015 03:24 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> I'm working on secure boot and I use sandbox & qemu to test it
BTW: what's your target ARCH, as I'm working on secure boot, too.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] sandbox cleanups
2015-03-10 14:32 ` Marc Kleine-Budde
@ 2015-03-10 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-10 15:01 ` Marc Kleine-Budde
0 siblings, 1 reply; 12+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2015-03-10 14:59 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: barebox
> On Mar 10, 2015, at 10:32 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 03/10/2015 03:24 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> I'm working on secure boot and I use sandbox & qemu to test it
>
> BTW: what's your target ARCH, as I'm working on secure boot, too.
6 different one
IMX6 is one of them
HAB4
I’m sending patch I need one or 2 weeks more and I’ll have a first full implenentation
Best Regards,
J.
>
> Marc
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 12+ messages in thread