From: Marc Kleine-Budde <mkl@pengutronix.de>
To: barebox@lists.infradead.org
Cc: sha@pengutronix.de
Subject: Re: [PATCH] state: fix range check on uint8 and uint32 variables
Date: Fri, 3 Jul 2015 16:16:22 +0200 [thread overview]
Message-ID: <55969936.5020904@pengutronix.de> (raw)
In-Reply-To: <1435932461-27674-1-git-send-email-mkl@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1165 bytes --]
On 07/03/2015 04:07 PM, Marc Kleine-Budde wrote:
> The patch "8bfd06f073c8 state: uint8: add range check for uint8" as applied not
> correctly to the repository. It was supposed to change the state_uint8_create()
> function:
>
> | static struct state_variable *state_uint8_create(struct state *state,
> |
> | su32 = xzalloc(sizeof(*su32));
> |
> | - param = dev_add_param_int(&state->dev, name, state_set_dirty,
> | - NULL, &su32->value, "%u", state);
> | + param = dev_add_param_int(&state->dev, name, state_uint8_set,
> | + NULL, &su32->value, "%u", su32);
>
> but the state_uint32_create() was changed instead, which leads to broken range
> checks on uint32 variables and no range checks on uint8. This patch fixes the
> problem.
Sorry for the noise, that error occurred while rebasing my code to the
current release....origin/next is fine.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-07-03 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 14:07 Marc Kleine-Budde
2015-07-03 14:08 ` Marc Kleine-Budde
2015-07-03 14:16 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55969936.5020904@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox