From: Oleksij Rempel <linux@rempel-privat.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v1 3/3] regulator: pfuze: provide power over standby handler
Date: Thu, 6 Jul 2017 18:34:30 +0200 [thread overview]
Message-ID: <56c7ef37-f608-6a9c-6a0f-4a0b8677f40f@rempel-privat.de> (raw)
In-Reply-To: <1499350371.23968.4.camel@pengutronix.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1372 bytes --]
Am 06.07.2017 um 16:12 schrieb Lucas Stach:
> Am Donnerstag, den 06.07.2017, 16:00 +0200 schrieb Oleksij Rempel:
>> This patch is providing an optional power off handler
>> which will configure standby state of the PMIC to disable all power lines.
>>
>> In my power consumption test on RIoTBoard, I got the following results:
>> power off without this patch: 320 mA
>> power off with this patch: 2 mA
>> suspend to ram: 40 mA
>
> You probably haven't measured suspend to ram with barebox, right? ;)
Oops... yeas :)
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>> drivers/regulator/pfuze.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 87 insertions(+)
>>
>> diff --git a/drivers/regulator/pfuze.c b/drivers/regulator/pfuze.c
>> index 2a5fb715ce..94fa03ff15 100644
>> --- a/drivers/regulator/pfuze.c
>> +++ b/drivers/regulator/pfuze.c
>> @@ -26,10 +26,53 @@
>>
>> #include <i2c/i2c.h>
>>
>> +#include <poweroff.h>
>> +#include <mach/imx6.h>
>> +
> This introduces a build dependency of the PFUZE driver to the i.MX6
> architecture. While I think this is fine, as it keeps things
> straight-forward and the PFUZE is unlikely to be used on other SoCs,
> this needs at least a "depends on ARCH_IMX6" in the Kconfig entry.
Ok.
--
Regards,
Oleksij
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2017-07-06 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 14:00 [PATCH v1 1/3] ARM: riotboard: provide standby on power off option Oleksij Rempel
2017-07-06 14:00 ` [PATCH v1 2/3] ARM: i.MX: provide handler for power off over standby Oleksij Rempel
2017-07-06 14:00 ` [PATCH v1 3/3] regulator: pfuze: provide power over standby handler Oleksij Rempel
2017-07-06 14:12 ` Lucas Stach
2017-07-06 16:34 ` Oleksij Rempel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c7ef37-f608-6a9c-6a0f-4a0b8677f40f@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox