Re: [PATCH v2 3/3] ARM: at91: microchip-ksz9477-evb: migrate to sama5d3_barebox_entry()

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 06.07.23 10:11, Oleksij Rempel wrote:
> We have sama5d3_barebox_entry(), so make use of it.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

I expected to see a /memory node removed, but I see now that I removed
them already in commit:
2e7e1d2512b0 ("ARM: AT91: sama5d3: always read memory size from controller")

Given that I missed selecting HAVE_AT91_DDRAMC, this means that booting
recent barebox without your first patch would lead to an error message during
boot up that initmem is used as no driver or DT added memory banks.
System should continue normally though.

For boards that already have a memory region in the DT, adding a memory
region by the driver that is identical should be silently accepted.

Could you verify this to make sure we don't introduce breakage?
That would also make patch 1 a candidate for being applied to master.

Thanks,
Ahmad


> ---
>  arch/arm/boards/microchip-ksz9477-evb/lowlevel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c b/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c
> index bda6a94160..aa2161daee 100644
> --- a/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c
> +++ b/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c
> @@ -58,5 +58,5 @@ SAMA5D3_ENTRY_FUNCTION(start_sama5d3_xplained_ung8071, r4)
>  
>  	fdt = __dtb_z_at91_microchip_ksz9477_evb_start + get_runtime_offset();
>  
> -	barebox_arm_entry(SAMA5_DDRCS, SZ_256M, fdt);
> +	sama5d3_barebox_entry(r4, fdt);
>  }

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |