From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 06 Jul 2023 10:33:47 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHKQu-00HQB9-KT for lore@lore.pengutronix.de; Thu, 06 Jul 2023 10:33:47 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHKQr-0005ly-Od for lore@pengutronix.de; Thu, 06 Jul 2023 10:33:46 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q+RfGPgzpWw4w3qiY1FFVh6M4XX0c2ZP4JzjOW1l/Hg=; b=sPJpoj2Q45dxQ7vRkoRkh60CqU 6srVsjLotB6xN/glSGoniS2WXDuwtm/37mEbE9Xv7RSQe2Cl5chat6jWF4nggNfEfooXU/DQMmc3K 3P17PeaUW4fmAANLCKVsR0EhIsa7l0zRITrDKaMjfUfPaSFxg7Z9j8VgWDE3xL7SLLrinLqsuhXVc x4+a2CNW1k0J4d6w4WWLed8ggTe3SZ97U/g/cqotrBJ6XtQh87oCTyMCuxLnGEiWCz2cjv3ZBRrjN Y+MLhxP1X0nURZAkP4RHneBcdfSevOqar/I26YvDUTK1FriwDjAMtdNDY6D69M67JItqVIFQ9r4e3 cyq2RCiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHKPk-000xcd-1n; Thu, 06 Jul 2023 08:32:36 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHKPh-000xc7-1O for barebox@lists.infradead.org; Thu, 06 Jul 2023 08:32:34 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qHKPf-0005iU-Gr; Thu, 06 Jul 2023 10:32:31 +0200 Message-ID: <577b4021-a9a4-dd65-4614-a5dd2df95428@pengutronix.de> Date: Thu, 6 Jul 2023 10:32:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Oleksij Rempel , barebox@lists.infradead.org References: <20230706081126.784759-1-o.rempel@pengutronix.de> <20230706081126.784759-3-o.rempel@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230706081126.784759-3-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_013233_468669_8186FA45 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 3/3] ARM: at91: microchip-ksz9477-evb: migrate to sama5d3_barebox_entry() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 06.07.23 10:11, Oleksij Rempel wrote: > We have sama5d3_barebox_entry(), so make use of it. > > Signed-off-by: Oleksij Rempel I expected to see a /memory node removed, but I see now that I removed them already in commit: 2e7e1d2512b0 ("ARM: AT91: sama5d3: always read memory size from controller") Given that I missed selecting HAVE_AT91_DDRAMC, this means that booting recent barebox without your first patch would lead to an error message during boot up that initmem is used as no driver or DT added memory banks. System should continue normally though. For boards that already have a memory region in the DT, adding a memory region by the driver that is identical should be silently accepted. Could you verify this to make sure we don't introduce breakage? That would also make patch 1 a candidate for being applied to master. Thanks, Ahmad > --- > arch/arm/boards/microchip-ksz9477-evb/lowlevel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c b/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c > index bda6a94160..aa2161daee 100644 > --- a/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c > +++ b/arch/arm/boards/microchip-ksz9477-evb/lowlevel.c > @@ -58,5 +58,5 @@ SAMA5D3_ENTRY_FUNCTION(start_sama5d3_xplained_ung8071, r4) > > fdt = __dtb_z_at91_microchip_ksz9477_evb_start + get_runtime_offset(); > > - barebox_arm_entry(SAMA5_DDRCS, SZ_256M, fdt); > + sama5d3_barebox_entry(r4, fdt); > } -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |