Re: [PATCH] fixup! tee: optee: implement RPMB support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Jules,

On 25.03.25 15:36, Jules Maselbas wrote:
> Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
> ---
>  drivers/tee/optee/rpmb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tee/optee/rpmb.c b/drivers/tee/optee/rpmb.c
> index cdc8afc1a4..ca60f3cf3d 100644
> --- a/drivers/tee/optee/rpmb.c
> +++ b/drivers/tee/optee/rpmb.c
> @@ -5,6 +5,7 @@
>  
>  #define pr_fmt(fmt)     "optee-rpmb: " fmt
>  
> +#include <common.h>

Is this only for ARRAY_SIZE? Then I'd prefer we include <linux/kernel.h> or
<linux/array_size.h>, because we generally want to cut down on use of
<common.h>, if only to reduce compile time a bit.

Also, please send fixups without a reply-to for patches that are already applied.
This makes it less likely to be missed IMO.

Cheers,
Ahmad



>  #include <mci.h>
>  
>  #include "optee_msg.h"


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |