mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ye Li <ye.li@oss.nxp.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	Peng Fan <peng.fan@nxp.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	dl-uboot-imx <uboot-imx@nxp.com>,
	Steffen Trumtrar <str@pengutronix.de>
Subject: Re: i.MX8/9: question about unused DDR PHY trained CSR board array
Date: Fri, 20 Dec 2024 20:06:44 +0800	[thread overview]
Message-ID: <582e0514-031c-4442-a45d-6b3d317fb9f5@oss.nxp.com> (raw)
In-Reply-To: <30375711-d4a8-4e53-a804-a721d45e0ac1@pengutronix.de>

Hi Ahmad,

On 12/20/2024 2:12 PM, Ahmad Fatoum wrote:
> [You don't often get email from a.fatoum@pengutronix.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Hello Ye Li,
>
> On 20.12.24 02:58, Ye Li wrote:
>> On 12/19/2024 6:27 PM, Ahmad Fatoum wrote:
>>> On 30.09.24 08:38, Peng Fan wrote:
>>>>> I now have the DDR settings for an i.MX9 LPDDR4 board in front of me
>>>>> that has different contents for struct
>>>>> dram_cfg_param::ddrphy_trained_csr than the default.
>>>>>
>>>>> I will inquire how that came about, but in parallel I wanted to ask you if
>>>>> this is supposed to happen and to alert you to this issue.
>>>> Thanks for raising this issue. I think board specific csr should be used.
>>>>
>>>> I will check with DDR TOOL owners on this.
>>> Did you hear back in the meantime?
>> We have discussed this internally. The DDR tool may generate different board specific csr. Currently in DDR retention, because we load csr + ddr_phy_pie, so it is safe to use this global csr.
> So ddr_phy_pie contains the firmware to the DDR PHY µC and it will
> train the PHY and thus will iron over any missing entries in the
> stored CSR? Is my understanding correct?

PIE is not used for training and does not contain firmware. It sequences 
PHY initialization like pll lock, power gating, etc.

Normally its configuration registers should be saved as a part of 
ddrphy_trained_csr list. Our DDR expert thinks the major missing in the 
global CSR is the PIE configuration registers.


Best regards,

Ye Li

>> But we agree this global csr is confused and waste some memory. It is better to switch to the board csr.
> Thanks for the confirmation.
>
> Cheers,
> Ahmad
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2024-12-20 12:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 14:08 Ahmad Fatoum
2024-09-30  6:38 ` Peng Fan
2024-12-19 10:27   ` Ahmad Fatoum
2024-12-20  1:58     ` Ye Li
2024-12-20  6:12       ` Ahmad Fatoum
2024-12-20 12:06         ` Ye Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=582e0514-031c-4442-a45d-6b3d317fb9f5@oss.nxp.com \
    --to=ye.li@oss.nxp.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=str@pengutronix.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox