mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@arri.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: <barebox@lists.infradead.org>
Subject: aiodev: imx7_adc driver
Date: Wed, 23 Aug 2023 16:53:04 +0200	[thread overview]
Message-ID: <5977114.lOV4Wx5bFT@n95hx1g2> (raw)

Hi Ahmad,

I am currently porting the vf610_adc driver from Linux to Barebox.
Must thing can be done similar as for the imx7_adc driver.

I have one question about the reference voltage:

static int imx7d_adc_enable(struct imx7d_adc *info)
{
...
	ret = regulator_get_voltage(info->vref);
...
}

What type of regulator do you use? I have declared a
fixed regulator in my device tree:

	reg_adc_vref_3v3: regulator-3v3-adc {
		compatible = "regulator-fixed";
		regulator-name = "vref-3v3";
		regulator-min-microvolt = <3300000>;
		regulator-max-microvolt = <3300000>;
	};

	&adc2 {
		pinctrl-names = "default";
		pinctrl-0 = <&pinctrl_adc2>;
		vref-supply = <&reg_adc_vref_3v3>;
	...
	};

But it looks like the fixed regulator driver in Barebox
doesn't support reading the voltage (the Linux driver
reports the value from "regulator-min-microvolt")?

regards,
Christian







             reply	other threads:[~2023-08-23 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 14:53 Christian Eggers [this message]
2023-08-23 15:05 ` Christian Eggers
2023-08-23 16:25   ` Ahmad Fatoum
2023-08-23 16:30     ` Christian Eggers
2023-08-23 16:32       ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5977114.lOV4Wx5bFT@n95hx1g2 \
    --to=ceggers@arri.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox