mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Tomaž Šolc" <tomaz.solc@klevio.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 5/5] ARM: rpi: Add mini UART debug_ll support
Date: Thu, 7 Mar 2019 10:52:33 +0100	[thread overview]
Message-ID: <5ad113f6-f0a3-0243-5fd0-57453ed057c6@klevio.com> (raw)
In-Reply-To: <20190306094239.29413-6-s.hauer@pengutronix.de>

Hi

On 6. 03. 19 10:42, Sascha Hauer wrote:
> diff --git a/common/Kconfig b/common/Kconfig
> index 563cf15fb1..0c6acfcddb 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1173,6 +1173,12 @@ config DEBUG_RPI2_UART
>   	  Say Y here if you want low-level debugging support on
>   	  RaspberryPi 2 and 3 boards.
>   
> +config DEBUG_RPI3_MINI_UART
> +	bool "RaspberryPi 3 mini UART

The line above is missing the closing double quote.

I also recommend changing the labels on other two UART options to say 
"PL011 UART" instead of "debug UART" so that the difference is more obvious.

Can you also please include in this series my patch that expands the 
help message for DEBUG_LL I sent earlier?

> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 3 board mini UART.
>   endchoice
>   
>   config DEBUG_IMX_UART_PORT
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-03-07  9:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  9:42 [PATCH 0/5] ARM: rpi: refactor debug_ll Sascha Hauer
2019-03-06  9:42 ` [PATCH 1/5] ARM: rpi: Move UART base address definitions to header file Sascha Hauer
2019-03-06  9:42 ` [PATCH 2/5] debug_ll: Move pl011 header file to architecture independent place Sascha Hauer
2019-03-06  9:42 ` [PATCH 3/5] debug_ll: Add ns16550 early debugging functions Sascha Hauer
2019-03-06  9:42 ` [PATCH 4/5] ARM: rpi: move debug UART Kconfig settings Sascha Hauer
2019-03-07  9:52   ` Tomaž Šolc
2019-03-06  9:42 ` [PATCH 5/5] ARM: rpi: Add mini UART debug_ll support Sascha Hauer
2019-03-07  9:52   ` Tomaž Šolc [this message]
2019-03-07 13:24     ` Sascha Hauer
2019-03-07 13:32       ` [HELP] Kernel + initrd in FIT Seraphim Dolbilov
2019-03-11  7:25         ` Sascha Hauer
2019-03-07 10:00 ` [PATCH 0/5] ARM: rpi: refactor debug_ll Tomaž Šolc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ad113f6-f0a3-0243-5fd0-57453ed057c6@klevio.com \
    --to=tomaz.solc@klevio.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox