mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Giandomenico Rossi <rossi@amelchem.com>, barebox@lists.infradead.org
Subject: Re: [PATCH v1 3/4] dt-bindings: display: panel: add Ilitek ILI9488 panel
Date: Mon, 23 Feb 2026 11:57:56 +0100	[thread overview]
Message-ID: <5b4c8e38-aae3-44c4-a4ef-648d5b6dc5ff@pengutronix.de> (raw)
In-Reply-To: <20260213191247.1671231-4-rossi@amelchem.com>

Hi,

On 2/13/26 8:12 PM, Giandomenico Rossi wrote:
> Add device tree binding documentation for TFT LCD panels based on
> the Ilitek ILI9488 controller connected via MIPI DBI Type-C Option 1
> over SPI.
> 
> The binding documents panels such as the WF35-320480UD operating in
> RGB666 (18-bit) pixel format and describes required GPIOs, power
> supply, optional backlight and panel timing.
> 
> A 'rotation' property is provided to configure the display
> orientation.
> 
> Signed-off-by: Giandomenico Rossi <rossi@amelchem.com>

This patch needs to go into Documentation/devicetree/bindings/ as
dts/Bindings are exclusively the upstream Linux bindings.

Maybe Sascha can do this when applying?

Cheers,
Ahmad

> ---
>  .../display/panel/panel-ilitek-ili9488.yaml   | 120 ++++++++++++++++++
>  1 file changed, 120 insertions(+)
>  create mode 100644 dts/Bindings/display/panel/panel-ilitek-ili9488.yaml
> 
> diff --git a/dts/Bindings/display/panel/panel-ilitek-ili9488.yaml b/dts/Bindings/display/panel/panel-ilitek-ili9488.yaml
> new file mode 100644
> index 0000000000..ceb14a5c25
> --- /dev/null
> +++ b/dts/Bindings/display/panel/panel-ilitek-ili9488.yaml
> @@ -0,0 +1,120 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/video/panel-ilitek-ili9488.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Ilitek ILI9488 TFT LCD Panel (MIPI DBI SPI)
> +
> +maintainers:
> +  - Giandomenico Rossi <rossi@amelchem.com>
> +
> +description: |
> +  Ilitek ILI9488 TFT LCD controller connected over MIPI DBI Type C
> +  Option 1 using an SPI bus.
> +
> +  Specific panels such as the Winstar WF35-320480UD may provide a
> +  vendor-specific compatible string followed by "ilitek,ili9488"
> +  as fallback.
> +
> +  The controller supports RGB666 (18-bit) pixel format over SPI.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: winstar,wf35-320480ud
> +          - const: ilitek,ili9488
> +      - const: ilitek,ili9488
> +
> +  reg:
> +    description: SPI chip select number
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    maximum: 48000000
> +    description: Maximum SPI clock frequency in Hz
> +
> +  reset-gpios:
> +    description: Optional hardware reset GPIO
> +    maxItems: 1
> +
> +  power-supply:
> +    description: Regulator supplying panel power
> +
> +  backlight:
> +    description: Phandle to a backlight device
> +
> +  rotation:
> +    description: |
> +      Display rotation in degrees clockwise.
> +
> +      The driver uses this value to configure the ILI9488
> +      Memory Access Control (MADCTL) register.
> +    enum: [0, 90, 180, 270]
> +    default: 0
> +
> +  panel-timing:
> +    description: |
> +      Panel timing description.
> +
> +      For MIPI DBI panels the pixel clock and porch values are ignored,
> +      but xactive/yactive must be provided.
> +    type: object
> +    properties:
> +      clock-frequency:
> +        description: Dummy pixel clock (may be 0)
> +      hactive:
> +        description: Horizontal resolution in pixels
> +      vactive:
> +        description: Vertical resolution in pixels
> +      hfront-porch:
> +        default: 0
> +      hback-porch:
> +        default: 0
> +      hsync-len:
> +        default: 0
> +      vfront-porch:
> +        default: 0
> +      vback-porch:
> +        default: 0
> +      vsync-len:
> +        default: 0
> +
> +    required:
> +      - hactive
> +      - vactive
> +
> +required:
> +  - compatible
> +  - reg
> +  - panel-timing
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        display@0 {
> +            compatible = "winstar,wf35-320480ud", "ilitek,ili9488";
> +            reg = <0>;
> +            spi-max-frequency = <40000000>;
> +
> +            reset-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
> +
> +            power-supply = <&vcc_3v3>;
> +            backlight = <&backlight>;
> +
> +            rotation = <90>;
> +
> +            panel-timing {
> +                hactive = <480>;
> +                vactive = <320>;
> +                clock-frequency = <0>;
> +            };
> +        };
> +    };

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2026-02-23 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 19:12 [PATCH v1 0/4] video: add ILI9488 panel support with MIPI DBI Type C1 Giandomenico Rossi
2026-02-13 19:12 ` [PATCH v1 1/4] video: mipi-dbi: support for MIPI DBI Type C Option 1 Giandomenico Rossi
2026-02-13 19:12 ` [PATCH v1 2/4] video: mipi-dbi: add display rotation support Giandomenico Rossi
2026-02-13 19:12 ` [PATCH v1 3/4] dt-bindings: display: panel: add Ilitek ILI9488 panel Giandomenico Rossi
2026-02-23 10:57   ` Ahmad Fatoum [this message]
2026-02-23 11:14     ` Sascha Hauer
2026-02-13 19:12 ` [PATCH v1 4/4] video: add Ilitek ILI9488 driver for WF35 panel Giandomenico Rossi
2026-02-23 10:48 ` [PATCH v1 0/4] video: add ILI9488 panel support with MIPI DBI Type C1 Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b4c8e38-aae3-44c4-a4ef-648d5b6dc5ff@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rossi@amelchem.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox