mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Bastian Stender <bst@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] fbconsole: check cursor position before moving
Date: Fri, 24 Feb 2017 11:18:41 +0000	[thread overview]
Message-ID: <5d50e55f-ff85-b306-aa74-fd5d2650c28a@mev.co.uk> (raw)
In-Reply-To: <20170224073227.vs2a5lhz7rc2b3g2@pengutronix.de>

On 24/02/17 07:32, Sascha Hauer wrote:
> On Thu, Feb 23, 2017 at 06:20:21PM +0100, Bastian Stender wrote:
>> Moving the cursor to x=2, y=2 with "\e[3;3H" on a 12x2 framebuffer
>> console lead to a barebox crash while drawing the cursor. The cursor can
>> only be moved to a valid position between (0,0) and (priv->cols,
>> priv->rows) now.
>>
>> Signed-off-by: Bastian Stender <bst@pengutronix.de>
>> ---
>>  drivers/video/fbconsole.c | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbconsole.c b/drivers/video/fbconsole.c
>> index 64f7d7364e..3879741b2a 100644
>> --- a/drivers/video/fbconsole.c
>> +++ b/drivers/video/fbconsole.c
>> @@ -264,10 +264,13 @@ static void fbc_parse_csi(struct fbc_priv *priv)
>>  		return;
>>  	case 'H':
>>  		video_invertchar(priv, priv->x, priv->y);
>> +
>>  		pos = simple_strtoul(priv->csi, &end, 10);
>> -		priv->y = pos ? pos - 1 : 0;
>> +		priv->y = (pos && pos <= priv->rows + 1) ? pos - 1 : 0;
>> +
>>  		pos = simple_strtoul(end + 1, NULL, 10);
>> -		priv->x = pos ? pos - 1 : 0;
>> +		priv->x = (pos && pos <= priv->cols + 1) ? pos - 1 : 0;
>> +
>
> When moving out of the screen shouldn't we place the cursor on the
> bottom right corner of the screen? With this patch we move it to the top
> left corner.

Or clip to each edge, something like:

  priv->y = !pos ? 0 : pos < priv->rows ? pos - 1 : priv->rows - 1;

Same for priv->x and priv->cols?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-02-24 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 17:20 Bastian Stender
2017-02-23 17:20 ` [PATCH 2/2] fbconsole: implement vt100 cursor shown/hidden Bastian Stender
2017-02-24  7:32 ` [PATCH 1/2] fbconsole: check cursor position before moving Sascha Hauer
2017-02-24 11:18   ` Ian Abbott [this message]
2017-02-24 13:22     ` Bastian Stender
2017-02-24 13:36       ` [PATCH v2] " Bastian Stender
2017-02-27  7:57         ` Sascha Hauer
2017-02-27 13:39           ` [PATCH v3] " Bastian Stender
2017-02-27 18:46             ` Ian Abbott
2017-02-27 18:51               ` Ian Abbott
2017-02-28  6:46             ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d50e55f-ff85-b306-aa74-fd5d2650c28a@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=barebox@lists.infradead.org \
    --cc=bst@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox