From: Jonas Rebmann <jre@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: BAREBOX <barebox@lists.infradead.org>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2 15/17] crypto: concatenate fit development certificate with private key
Date: Mon, 3 Nov 2025 12:41:14 +0100	[thread overview]
Message-ID: <5d5a5331-9cc8-426a-85ea-cdb288fdf265@pengutronix.de> (raw)
In-Reply-To: <aQh_K6q-F2Og-vhb@pengutronix.de>
Hi Sascha,
On 2025-11-03 11:08, Sascha Hauer wrote:
> On Tue, Oct 28, 2025 at 07:03:20PM +0100, Jonas Rebmann wrote:
>> Merge the exemplary keys copied in from [1] into a single pem file,
>> in a manner similar to test/self/development_rsa2048.pem for consistency
>> and to reduce clutter a bit.
>>
>> While at it, rename them from "fit-" to "snakeoil-" as they are not only
>> used for fit, but also for tlv integration tests, and to indicate more
>> clearly that these are publicly known keys.
> 
> Should we rather keep the "fit" name and add another key for tlv
> integration tests?
I'd rather not add more 'compromised' keys to the repo. What would be
the gain?
I think naming it snakeoil gives it the warning it deserves. We should
make it hard for anyone to confuse our CI/Development keys with their
production keys.
Ahmad was concerned about cluttering the repo with keys I think, that's
why he asked me to concatenated public key and certificate here.
Regards,
Jonas
-- 
Pengutronix e.K.                           | Jonas Rebmann               |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |
next prev parent reply	other threads:[~2025-11-03 11:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 18:03 [PATCH v2 00/17] TLV-Signature and keyrings Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 01/17] lib: idr: avoid dangling else in idr_for_each_entry() Jonas Rebmann
2025-11-03 10:11   ` Ahmad Fatoum
2025-10-28 18:03 ` [PATCH v2 02/17] common: clean up TLV code Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 03/17] crypto: Add support for keyrings Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 04/17] fit: only accept keys from "fit"-keyring Jonas Rebmann
2025-11-03  9:04   ` Sascha Hauer
2025-10-28 18:03 ` [PATCH v2 05/17] crypto: keytoc: Rename "hint" to "fit-hint" and do not use it in identifiers Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 06/17] commands: keys: update output format to include keyring Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 07/17] commands: tlv: Error out on invalid TLVs Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 08/17] scripts: bareboxtlv-generator: Implement signature Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 09/17] scripts: bareboxtlv-generator: Increase max_size in example schema Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 10/17] common: tlv: Add TLV-Signature support Jonas Rebmann
2025-11-03 10:02   ` Sascha Hauer
2025-11-03 11:21     ` Jonas Rebmann
2025-11-03 11:41       ` Sascha Hauer
2025-11-03 11:55         ` Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 11/17] common: tlv: default decoder for signed TLV Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 12/17] crypto: Use "development" keys for "fit" and "tlv" keyring Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 13/17] test: py: add signature to TLV integration tests Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 14/17] ci: pytest: Add kconfig fragment for TLV signature " Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 15/17] crypto: concatenate fit development certificate with private key Jonas Rebmann
2025-11-03 10:08   ` Sascha Hauer
2025-11-03 11:41     ` Jonas Rebmann [this message]
2025-10-28 18:03 ` [PATCH v2 16/17] doc/barebox-tlv: Update documentation regarding TLV-Signature Jonas Rebmann
2025-10-28 18:03 ` [PATCH v2 17/17] Documentation: migration-2025.11.0: List changes to CONFIG_CRYPTO_PUBLIC_KEYS Jonas Rebmann
2025-11-03 10:16   ` Sascha Hauer
2025-11-03 10:26     ` Ahmad Fatoum
2025-11-03 10:41       ` Sascha Hauer
2025-11-03 10:45         ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=5d5a5331-9cc8-426a-85ea-cdb288fdf265@pengutronix.de \
    --to=jre@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox