[PATCH] treewide: Fix wrong EXPORT_SYMBOL()

[PATCH] treewide: Fix wrong EXPORT_SYMBOL()

[Sascha Hauer]

- duplicate EXPORT_SYMBOL_GPL(gpio_request_one), one should be
  EXPORT_SYMBOL_GPL(gpiod_request_one) instead
- duplicate EXPORT_SYMBOL(ucs2_strncmp), one should be
  EXPORT_SYMBOL(ucs2_strcmp) instead

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/gpio/gpiolib.c | 3 +--
 lib/ucs2_string.c      | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e1493ffb66..582f3fe58f 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -662,8 +662,7 @@ struct gpio_desc *gpiod_request_one(unsigned gpio,
 
 	return desc;
 }
-EXPORT_SYMBOL_GPL(gpio_request_one);
-
+EXPORT_SYMBOL_GPL(gpiod_request_one);
 
 /**
  * gpio_request_one - request a single GPIO with initial configuration
diff --git a/lib/ucs2_string.c b/lib/ucs2_string.c
index db3f34f6b7..6f027010d3 100644
--- a/lib/ucs2_string.c
+++ b/lib/ucs2_string.c
@@ -113,7 +113,7 @@ ucs2_strcmp(const ucs2_char_t *a, const ucs2_char_t *b)
 {
 	return ucs2_strncmp(a, b, ~0UL);
 }
-EXPORT_SYMBOL(ucs2_strncmp);
+EXPORT_SYMBOL(ucs2_strcmp);
 
 unsigned long
 ucs2_utf8size(const ucs2_char_t *src)
-- 
2.47.3

Re: [PATCH] treewide: Fix wrong EXPORT_SYMBOL()

[Ahmad Fatoum]

Hello Sascha,

On 1/16/26 10:18, Sascha Hauer wrote:
> - duplicate EXPORT_SYMBOL_GPL(gpio_request_one), one should be
>   EXPORT_SYMBOL_GPL(gpiod_request_one) instead
> - duplicate EXPORT_SYMBOL(ucs2_strncmp), one should be
>   EXPORT_SYMBOL(ucs2_strcmp) instead
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Is this not a subset of
https://lore.barebox.org/barebox/20260115115924.3428886-6-a.fatoum@barebox.org/T/#u

?

Thanks,
Ahmad

> ---
>  drivers/gpio/gpiolib.c | 3 +--
>  lib/ucs2_string.c      | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index e1493ffb66..582f3fe58f 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -662,8 +662,7 @@ struct gpio_desc *gpiod_request_one(unsigned gpio,
>  
>  	return desc;
>  }
> -EXPORT_SYMBOL_GPL(gpio_request_one);
> -
> +EXPORT_SYMBOL_GPL(gpiod_request_one);
>  
>  /**
>   * gpio_request_one - request a single GPIO with initial configuration
> diff --git a/lib/ucs2_string.c b/lib/ucs2_string.c
> index db3f34f6b7..6f027010d3 100644
> --- a/lib/ucs2_string.c
> +++ b/lib/ucs2_string.c
> @@ -113,7 +113,7 @@ ucs2_strcmp(const ucs2_char_t *a, const ucs2_char_t *b)
>  {
>  	return ucs2_strncmp(a, b, ~0UL);
>  }
> -EXPORT_SYMBOL(ucs2_strncmp);
> +EXPORT_SYMBOL(ucs2_strcmp);
>  
>  unsigned long
>  ucs2_utf8size(const ucs2_char_t *src)


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] treewide: Fix wrong EXPORT_SYMBOL()

[Sascha Hauer]

On Fri, Jan 16, 2026 at 11:17:01AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 1/16/26 10:18, Sascha Hauer wrote:
> > - duplicate EXPORT_SYMBOL_GPL(gpio_request_one), one should be
> >   EXPORT_SYMBOL_GPL(gpiod_request_one) instead
> > - duplicate EXPORT_SYMBOL(ucs2_strncmp), one should be
> >   EXPORT_SYMBOL(ucs2_strcmp) instead
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> 
> Is this not a subset of
> https://lore.barebox.org/barebox/20260115115924.3428886-6-a.fatoum@barebox.org/T/#u

Indeed, yes. I only read that you added missing EXPORT_SYMBOL, not
removed duplicate ones. Ok, we can disregard this one.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |