mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Clément Leger" <cleger@kalrayinc.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] Allow parsing more than one memory node
Date: Tue, 17 Mar 2020 09:19:29 +0100 (CET)	[thread overview]
Message-ID: <645334065.10446584.1584433169193.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <20200317073544.GA31188@ravnborg.org>

Hi Sam,

----- On 17 Mar, 2020, at 08:35, Sam Ravnborg sam@ravnborg.org wrote:

> Hi Clement.
> 
> On Mon, Mar 16, 2020 at 12:00:06PM +0100, Clement Leger wrote:
>> Currently, barebox can only parse one memory node. This means that
>> all other memory nodes (with device_type == "memory") will be ignored
>> while parsing memory.
>> This patchset add a function of_probe_memory which will call
>> of_add_memory for each found memory node. Additionally, of_add_memory
>> has been modified to allow being called multiple times and correctly
>> add all memory banks.
>> 
>> Clement Leger (2):
>>   of: base: parse all available memory nodes
>>   of: base: allow of_add_memory to be called multiple times
> 
> With this order of the patches, after applying patch 1 the
> code will then use the last and not the first memory node.
> And only after the second patch it will work.
> 
> I think to improve bisectability the order of the two patches should be
> reversed.

Oh yes indeed ! I will send a V2 after others have commented it.

> 
> 	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-03-17  8:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 11:00 Clement Leger
2020-03-16 11:00 ` [PATCH 1/2] of: base: parse all available memory nodes Clement Leger
2020-03-23 10:12   ` Sascha Hauer
2020-03-23 10:21     ` Clément Leger
2020-03-23 10:31       ` Ahmad Fatoum
2020-03-25  9:29         ` Sascha Hauer
2020-06-18 10:16           ` Ahmad Fatoum
2020-03-16 11:00 ` [PATCH 2/2] of: base: allow of_add_memory to be called multiple times Clement Leger
2020-03-25 17:27   ` [PATCH v2 0/2] Allow parsing more than one memory node Clement Leger
2020-03-25 17:27     ` [PATCH v2 1/2] of: base: allow of_add_memory to be called multiple times Clement Leger
2020-03-25 17:27     ` [PATCH v2 2/2] of: base: parse all available memory nodes Clement Leger
2020-03-30  5:31     ` [PATCH v2 0/2] Allow parsing more than one memory node Sascha Hauer
2020-03-17  7:35 ` [PATCH " Sam Ravnborg
2020-03-17  8:19   ` Clément Leger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=645334065.10446584.1584433169193.JavaMail.zimbra@kalray.eu \
    --to=cleger@kalrayinc.com \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox