mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>, barebox@lists.infradead.org
Subject: Re: [PATCH] devinfo: Omit parent if direct descendent of bus
Date: Mon, 29 Nov 2021 09:07:33 +0100
Message-ID: <64da1ffd-3034-c42b-9e5c-bdafbde4b537@pengutronix.de> (raw)
In-Reply-To: <20211129071542.2014668-1-ahmad@a3f.at>

On 29.11.21 08:15, Ahmad Fatoum wrote:
> In that case parentage adds no extra info, so we can just omit it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---

Please dismiss. Sent out a (misnamed) v2 just now.

>  commands/devinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/devinfo.c b/commands/devinfo.c
> index 2e2e48e42cc5..b4894cc9272d 100644
> --- a/commands/devinfo.c
> +++ b/commands/devinfo.c
> @@ -85,7 +85,7 @@ static int do_devinfo(int argc, char *argv[])
>  		if (dev->info)
>  			dev->info(dev);
>  
> -		if (dev->parent)
> +		if (dev->parent && dev->parent != dev->bus->dev)
>  			printf("Parent: %s\n", dev_name(dev->parent));
>  
>  		first = true;
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-11-29  8:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  7:15 Ahmad Fatoum
2021-11-29  8:07 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64da1ffd-3034-c42b-9e5c-bdafbde4b537@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git