From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
barebox@lists.infradead.org
Subject: Re: [PATCH] net:fec: fixed unaligned access and stack corruption
Date: Sat, 11 Jul 2020 07:13:11 +0200 [thread overview]
Message-ID: <6525ec7f-c391-4394-4eef-6777459b94da@pengutronix.de> (raw)
In-Reply-To: <20200711050719.GP15485@pengutronix.de>
On 7/11/20 7:07 AM, Sascha Hauer wrote:
> On Tue, Jul 07, 2020 at 07:11:31PM +0200, Ahmad Fatoum wrote:
>> On 7/7/20 6:01 PM, Enrico Scholz wrote:
>>> on 64 bit architectures, the 'enum fec_type' might not be aligned and
>>> large enough to hold a pointer.
>>
>> I am wondering if we couldn't just adopt the Linux prototype:
>> void *dev_get_drvdata(const struct device_d *dev);
>>
>> and do away with the error code and most of the casts.
>> Users won't be able to differentiate between NULL from id table
>> and NULL due to lack of drvdata, but I don't think this is
>> that much of a downside, compared with not having casts obscure
>> the more common pitfall (besides fec_imx.c, lm75.c, apbh_dma.c and nand_mxs.c
>> are affected as well of which probably only the first is an issue.)
>
> Sounds good. When we change this we should rename the function
> alongside, because dev_get_drvdata() does something different in Linux.
Does it? I thought it does the same, with the difference that it can
be set with dev_set_drvdata as well. At the cost of one extra pointer
per device_d, we could have both of them.
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-11 5:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 16:01 Enrico Scholz
2020-07-07 17:11 ` Ahmad Fatoum
2020-07-11 5:07 ` Sascha Hauer
2020-07-11 5:13 ` Ahmad Fatoum [this message]
2020-07-11 5:20 ` Sascha Hauer
2020-07-11 5:28 ` Ahmad Fatoum
2020-07-14 18:39 ` Sascha Hauer
2020-07-30 21:13 ` Marco Felsch
2020-07-30 21:23 ` Ahmad Fatoum
2020-07-30 21:33 ` Marco Felsch
2020-07-11 5:12 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6525ec7f-c391-4394-4eef-6777459b94da@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox