mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] startup: add $global.autoboot to make behavior configurable
Date: Wed, 22 Apr 2020 09:29:47 +0200	[thread overview]
Message-ID: <65f0737a-3853-c266-26fd-3d14c3e1bbf0@pengutronix.de> (raw)
In-Reply-To: <20200420140824.GE1694@pengutronix.de>

Hi,

On 4/20/20 4:08 PM, Sascha Hauer wrote:
>> +	globalvar_add_simple_enum("autoboot",
>> +				  &autoboot_state,
>> +				  autoboot_states,
>> +				  ARRAY_SIZE(autoboot_states));
> 
> Please add a MAGICVAR description for this.

Will do.

> Setting it to AUTOBOOT_BOOT seems a bit dangerous, there's no way back
> if booting goes wrong.

You can still abort init itself with ctrl+c, not much different than when
using normal countdown.

> 
> Sascha
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-04-22  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  9:36 Ahmad Fatoum
2020-04-20 14:08 ` Sascha Hauer
2020-04-22  7:29   ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65f0737a-3853-c266-26fd-3d14c3e1bbf0@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox