mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@arri.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, ceggers@gmx.de
Subject: Re: [SPAM:54%] Re: [PATCH] barebox_banner: switch to pr_notice
Date: Tue, 28 Jan 2020 10:39:10 +0100	[thread overview]
Message-ID: <6607783.M6Blm0jaCt@n95hx1g2> (raw)
In-Reply-To: <20200128093319.riamlkm6ihgoh7c2@pengutronix.de>

Am Dienstag, 28. Januar 2020, 10:33:19 CET schrieb Sascha Hauer:
> On Mon, Jan 27, 2020 at 08:46:06AM +0100, Christian Eggers wrote:
> > The banner should already be printed, if CONFIG_COMPILE_LOGLEVEL is set
> > to 5 (notice). If printing of the banner is not desired, CONFIG_BANNER
> > can be disabled.
> 
> With that argument you could put it in any loglevel you want to.
that's right. Do you like to insert the highest possible log level for this 
particular case?

> I am fine with the patch, but can we reword to something like "print
> important message on higher loglevel?
Yes, of course. Do you like a new patch or would you change this yourself?

regards
Christian




_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-01-28  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  7:46 Christian Eggers
2020-01-28  9:33 ` Sascha Hauer
2020-01-28  9:39   ` Christian Eggers [this message]
2020-01-28  9:59     ` [SPAM:54%] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6607783.M6Blm0jaCt@n95hx1g2 \
    --to=ceggers@arri.de \
    --cc=barebox@lists.infradead.org \
    --cc=ceggers@gmx.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox