Re: [PATCH] test: py: add dry run check for FIT image

[Ahmad Fatoum <a.fatoum@barebox.org>]

Hi,

On 1/19/26 12:26 PM, Sascha Hauer wrote:
> On Fri, Jan 16, 2026 at 11:14:03AM +0100, Ahmad Fatoum wrote:
>> A dry run should not alter system state in a way that would inhibit
>> normal operation or repeated dry runs.
>>
>> The FIT image boot in the test suite, however, reduces the VFS root's
>> reference count beyond the initial value before the bootm.
>>
>> This leads to a warning on boot that can be reproduced by repeating the
>> dry run multiple times:
>>
>>   FAILED test/py/test_fit.py::test_fit_dryrun -
>> 	AssertionError: ['WARNING: at fs/fs.c:255/mntput()!',
>> 			 'WARNING: refcount for mount "/" becomes negative']
>>
>> Add a regression test for this issue.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
>> ---
>> @Sascha, given that you introduced the warning, maybe you are interested
>> in looking into this? :-)
>> I am not sure if it's 9PFS related. It's reproducible with:
> 
> No, it's not 9pfs related. It's the O_TMPFILE creation that bites us
> here. I've sent a fix.

Thank you!
Ahmad

> 
> Sascha
>