From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 Jan 2025 15:37:09 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tYQzc-000dAU-2O for lore@lore.pengutronix.de; Thu, 16 Jan 2025 15:37:09 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tYQzc-0007RF-NJ for lore@pengutronix.de; Thu, 16 Jan 2025 15:37:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=edNlaYOfCjmK7WawQWwX7jMIE0K4mgp+7r3HZ+e+YGE=; b=PYpWrvXB6jJqUavksLQdOHQn88 bPDYpkWmfERxmlpLlUkNVFutRmv8tv8IdGPUSbIHjTTEowxX+OVZ5mSh3+MwHoI9H1VJOwPvSXxUI Lm3YpOTkrOXienw7u/AHFqIbO8onqlkbjlN1nGZf4zbVaTKAQWK2bp38dMZfqmHJ79tDtTsznzcyx om2UUpFDyC/dH4/SWAVJ33YFqrjpaTSb1JaA9LHD+82bjdjq5xnG+7J4hapQGGYkkBuivSA9ewJQw kgga4dWNqRNd5yluKRMwRAIT9poU3DIfctJZYC0yIDgAv0Hz0+nI6FnlekXmufpExV5wDQJxfzkq1 YbTNFsUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYQzF-0000000FC2R-2C4q; Thu, 16 Jan 2025 14:36:45 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tYQyA-0000000FBl7-19LX for barebox@lists.infradead.org; Thu, 16 Jan 2025 14:35:39 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tYQy9-00072f-3x; Thu, 16 Jan 2025 15:35:37 +0100 Message-ID: <6889c57e-1658-4546-a748-acbf772f3dfc@pengutronix.de> Date: Thu, 16 Jan 2025 15:35:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Bastian Krause , Sascha Hauer , Barebox List References: <20250116093859.1676220-1-s.hauer@pengutronix.de> <8fe69a9e-65e9-4746-87ec-005a55658d37@pengutronix.de> <0ca78f8e-f4bd-4790-b269-3492cc9e6eb1@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <0ca78f8e-f4bd-4790-b269-3492cc9e6eb1@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_063538_310509_843EAEAC X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] ARM: i.MX: HAB: Allow for semicolons in HAB environment variables X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 16.01.25 15:34, Bastian Krause wrote: > On 1/16/25 2:50 PM, Ahmad Fatoum wrote: >> On 16.01.25 12:26, Bastian Krause wrote: >>> On 1/16/25 12:12 PM, Ahmad Fatoum wrote: >>>> On 16.01.25 10:38, Sascha Hauer wrote: >>>>> With CONFIG_HAB_CERTS_ENV=y, paths and PKCS#11 URIs to the HAB >>>>> certificates are taken from environment variables (allowing for better >>>>> integration with build systems). In this case these values are passed >>>>> internally via compiler macros (-D) to the imx-image host tool. PKCS#11 >>>>> URIs usually contain semicolons. The semicolons didn't make it through >>>>> to the imx-image configuration file due to wrong escapes. Fix this by >>>>> expanding the environment variables using make rather than shell. >>>>> >>>>> Signed-off-by: Sascha Hauer >>>>> --- >>>>>    scripts/Makefile.lib | 2 +- >>>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib >>>>> index f195ddb7e8..7dcd8c9892 100644 >>>>> --- a/scripts/Makefile.lib >>>>> +++ b/scripts/Makefile.lib >>>>> @@ -579,7 +579,7 @@ cmd_imximage_S_dcd=                        \ >>>>>    overwrite-hab-env = $(shell set -e; \ >>>>>          test -n "$(CONFIG_HAB_CERTS_ENV)"; \ >>>>>          test -n "$$$(1)"; \ >>>>> -      echo -D$(1)=\\\"$(shell echo $$$(1))\\\") >>>>> +      echo -D$(1)=\''"${${1}}"'\') >>>> >>>> Does {} and () make a difference here? >>> >>> I don't think so. This also works: >>> >>> -      echo -D$(1)=\''"${${1}}"'\') >>> +      echo -D$(1)=\''"$($(1))"'\') >> >> Thanks for testing. @Sascha, can you switch to using () instead? >> Otherwise it's confusing to have $(1) on the left-hand side, >> but ${1} on the right. > > Makes sense. > >> >> (My personal favorite would be -D$(1)=$(call stringify,$($(1))) FWIW, >> provided that it works as intended) > > Unfortunately.. > > -      echo -D$(1)=\''"${${1}}"'\') > +      echo -D$(1)=$(call stringify,$($(1)))) > > ..does not work if the value contains a semicolon. :-( Thanks for testing, Ahmad > > Regards, > Bastian > >> >> Thanks, >> Ahmad >> >>> >>> Bastian >>> >>>> >>>>>      overwrite-fit-env = $(shell set -e; \ >>>>>          test -n "$(CONFIG_BOOTM_FITIMAGE_PUBKEY_ENV)"; \ >>>> >>>> >>> >>> >> >> > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |