[PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[Bo Shen]

On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let
the EMAC auto detect phy addr, or else hard code to 0, the
ethernet can not work on SAMA5D35 board.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---

 arch/arm/boards/sama5d3xek/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boards/sama5d3xek/init.c b/arch/arm/boards/sama5d3xek/init.c
index 5cd2f29..3efa506 100644
--- a/arch/arm/boards/sama5d3xek/init.c
+++ b/arch/arm/boards/sama5d3xek/init.c
@@ -128,7 +128,7 @@ static struct macb_platform_data gmac_pdata = {
 
 static struct macb_platform_data macb_pdata = {
 	.phy_interface = PHY_INTERFACE_MODE_RMII,
-	.phy_addr = 0,
+	.phy_addr = -1,
 };
 
 static bool used_23 = false;
-- 
2.3.0.rc0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[Sascha Hauer]

On Thu, Jan 22, 2015 at 03:26:53PM +0800, Bo Shen wrote:
> On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let
> the EMAC auto detect phy addr, or else hard code to 0, the
> ethernet can not work on SAMA5D35 board.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

There ere boards with different phy addresses around, so
the current state does not work on all boards anyway. So the worst
thing that can happen with this and the other patch for the gmac is
that now another set of boards does not work. Let's give it a try.
I'm open to reports when now some board stops working.

Applied this and the gmac patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[Jean-Christophe PLAGNIOL-VILLARD]

> On Jan 23, 2015, at 3:51 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> On Thu, Jan 22, 2015 at 03:26:53PM +0800, Bo Shen wrote:
>> On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let
>> the EMAC auto detect phy addr, or else hard code to 0, the
>> ethernet can not work on SAMA5D35 board.
>> 
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> 
> There ere boards with different phy addresses around, so
> the current state does not work on all boards anyway. So the worst
> thing that can happen with this and the other patch for the gmac is
> that now another set of boards does not work. Let's give it a try.
> I'm open to reports when now some board stops working.
> 
> Applied this and the gmac patch.

except we can auto detect the board we are running from
so it will be better to specify it at Run time

as we have issue on auto detect on some of them

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[Sascha Hauer]

On Fri, Jan 23, 2015 at 03:53:48PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
> > On Jan 23, 2015, at 3:51 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > 
> > On Thu, Jan 22, 2015 at 03:26:53PM +0800, Bo Shen wrote:
> >> On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let
> >> the EMAC auto detect phy addr, or else hard code to 0, the
> >> ethernet can not work on SAMA5D35 board.
> >> 
> >> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> > 
> > There ere boards with different phy addresses around, so
> > the current state does not work on all boards anyway. So the worst
> > thing that can happen with this and the other patch for the gmac is
> > that now another set of boards does not work. Let's give it a try.
> > I'm open to reports when now some board stops working.
> > 
> > Applied this and the gmac patch.
> 
> except we can auto detect the board we are running from
> so it will be better to specify it at Run time
> 
> as we have issue on auto detect on some of them

Ok, so your suggestion is to detect the board (type, revision?) and
set phy_addr correctly based on this information, right? Fine with me
aswell. Is it known which boards have which phy_addr?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: atmel: sama5d3xek: let emac auto detect phy addr

[Jean-Christophe PLAGNIOL-VILLARD]

> On Jan 23, 2015, at 4:04 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> On Fri, Jan 23, 2015 at 03:53:48PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> 
>>> On Jan 23, 2015, at 3:51 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>>> 
>>> On Thu, Jan 22, 2015 at 03:26:53PM +0800, Bo Shen wrote:
>>>> On the SAMA5D35 the EMAC phy addr is 1 while not 0. So, let
>>>> the EMAC auto detect phy addr, or else hard code to 0, the
>>>> ethernet can not work on SAMA5D35 board.
>>>> 
>>>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>> 
>>> There ere boards with different phy addresses around, so
>>> the current state does not work on all boards anyway. So the worst
>>> thing that can happen with this and the other patch for the gmac is
>>> that now another set of boards does not work. Let's give it a try.
>>> I'm open to reports when now some board stops working.
>>> 
>>> Applied this and the gmac patch.
>> 
>> except we can auto detect the board we are running from
>> so it will be better to specify it at Run time
>> 
>> as we have issue on auto detect on some of them
> 
> Ok, so your suggestion is to detect the board (type, revision?) and
> set phy_addr correctly based on this information, right? Fine with me
> aswell. Is it known which boards have which phy_addr?

yes and I already write the detection code in barebox

Best Regards,
J.
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox