From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] kbuild: add dtbs target for building all dtbs of an ARCH
Date: Mon, 6 Jul 2020 00:31:09 +0200 [thread overview]
Message-ID: <6be7e02f-a8a6-e76f-9960-ccff916bcf54@pengutronix.de> (raw)
In-Reply-To: <20200705173513.GX15485@pengutronix.de>
On 7/5/20 7:35 PM, Sascha Hauer wrote:
> On Thu, Jul 02, 2020 at 10:59:34AM +0200, Ahmad Fatoum wrote:
>> As described in the documentation, upstream device trees extended by
>> barebox should take care to cause compile errors, not runtime errors,
>> when the paths they extend disappear. This way, breakage can be easily
>> detected when synchronizing the dts/ directory and fixed right then.
>>
>> Make this process easier by providing a dtbs target that builds all
>> device trees in arch/$(SRCARCH)/dts/ if available.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> Makefile | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 0da032532712..9fa741966c00 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -990,6 +990,20 @@ include/generated/version.h: FORCE
>> include/generated/utsrelease.h: include/config/kernel.release FORCE
>> $(call filechk,utsrelease.h)
>>
>> +# ---------------------------------------------------------------------------
>> +# Devicetree files
>> +
>> +ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/dts/),)
>> +dtstree := arch/$(SRCARCH)/dts
>> +endif
>> +
>> +ifneq ($(dtstree),)
>> +
>> +PHONY += dtbs
>> +dtbs: $(patsubst $(srctree)/%.dts,$(objtree)/%.dtb,$(wildcard $(srctree)/$(dtstree)/*.dts))
>> +
>> +endif
>
> Can we do this in a way that only rebuilds the changed files and not
> every dts again?
Probably, I would have to check how though. But it doesn't matter that much IMO.
Target is meant to be run only after dts/ update. It's not part of the normal
development workflow.
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-07-05 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 8:59 Ahmad Fatoum
2020-07-05 17:35 ` Sascha Hauer
2020-07-05 22:31 ` Ahmad Fatoum [this message]
2020-07-09 14:17 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be7e02f-a8a6-e76f-9960-ccff916bcf54@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox