Re: [PATCH v1] spi: add STM32F7 QSPI controller driver

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Oleksij,

On 3/31/25 14:29, Oleksij Rempel wrote:
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> Introduce support for the STM32F7 QSPI controller, compatible with
> "st,stm32f469-qspi".
> 
> Validated on STM32MP133-based MECT1S r1 board, which includes an
> F7-compatible QSPI peripheral
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

[snip]

> +static int stm32_qspi_get_mode(u8 buswidth)

Is this ever called with a buswidth > 1? I think the spi_mem core in
barebox never uses higher buswidths. Given that you are adding QSPI
support, you will surely want to see quad buswidth actually working,
right? :D

> +{
> +	if (buswidth >= 4)
> +		return CCR_BUSWIDTH_4;
> +
> +	return buswidth;
> +}

Cheers,
Ahmad

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |